Skip to content

Conversation

@rscales
Copy link

@rscales rscales commented Aug 8, 2025

Add additional SQLDescribeCol validation to the SQLGetTypeInfo test cases.

alinaliBQ
alinaliBQ previously approved these changes Aug 8, 2025
Copy link

@alinaliBQ alinaliBQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rscales rscales marked this pull request as ready for review August 8, 2025 20:53
@alinaliBQ alinaliBQ dismissed their stale review August 8, 2025 21:20

Please add SQLDecribeCol checks for rest of SQLColumns metadata. I think there are around 18 columns, currently the tests are only checking the first 5 I think

@rscales rscales mentioned this pull request Aug 11, 2025
Copy link

@alinaliBQ alinaliBQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rscales rscales merged commit 7570b5c into apache-odbc Aug 12, 2025
24 checks passed
@alinaliBQ alinaliBQ deleted the sql-describe-col-test branch August 28, 2025 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants