Skip to content

Conversation

@rscales
Copy link

@rscales rscales commented Jul 31, 2025

Implement SQLDescribeCol

Copy link

@alinaliBQ alinaliBQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Friendly reminder: To write SQLDescribeCol tests for SQLGetTypeInfo, pls rebase or merge from apache-odbc.

@rscales rscales marked this pull request as ready for review August 7, 2025 17:44
alinaliBQ
alinaliBQ previously approved these changes Aug 7, 2025
Copy link

@alinaliBQ alinaliBQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, minor comments

@alinaliBQ alinaliBQ self-requested a review August 7, 2025 20:25
@alinaliBQ alinaliBQ dismissed their stale review August 7, 2025 20:26

sorry I missed James' comment

Copy link

@alinaliBQ alinaliBQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rscales rscales merged commit e7d8794 into apache-odbc Aug 8, 2025
24 checks passed
@alinaliBQ alinaliBQ deleted the sql-describe-col branch August 28, 2025 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants