[#86787] [Ruby trunk Feature#14723] [WIP] sleepy GC — ko1@...

Issue #14723 has been updated by ko1 (Koichi Sasada).

13 messages 2018/05/01
[#86790] Re: [Ruby trunk Feature#14723] [WIP] sleepy GC — Eric Wong <normalperson@...> 2018/05/01

ko1@atdot.net wrote:

[#87095] [Ruby trunk Feature#14767] [PATCH] gc.c: use monotonic counters for objspace_malloc_increase — ko1@...

Issue #14767 has been updated by ko1 (Koichi Sasada).

9 messages 2018/05/17

[ruby-core:87076] Re: [Ruby trunk Misc#14762] [PATCH] gc.c: use ccan/list

From: Eric Wong <normalperson@...>
Date: 2018-05-16 09:38:13 UTC
List: ruby-core #87076
ko1@atdot.net wrote:
> No strong opinion.
> 
> They are memo:
> 
> I tried to reorder sweeping list by (a) "full page (all slots are living)" and (b)"can sweep page (there are some free-able slots)" and sweep only (b).
> No big improvement though :p
> 
> I think using ccan we can move the order, so we can try it later?

Yes, ccan/list should make reordering and experimentation
simpler.

> If we have any trouble to modify them using more complex strategy, we can revert it.
> 
> 
> Trivial comments:

> * The field name `sweep_pos` seems index for me. Maybe
> `sweeping_page` or something is fine for me.

Right, I think of it as an index to the main ->pages list; so I
used '_pos' suffix.  I guess `sweeping_page` along with comment
clarifying it is a pointer inside ->pages is OK.

> * Every time I feel magical for the name `node` (for CCAN
> list). Should I endure? (page_node or something is clear, but
> verbose I agree).

I only wondered about confusion with T_NODE type.
I suppose `page_node` is OK, but I prefer shorter names
(since I need big fonts)

Unsubscribe: <mailto:ruby-core-request@ruby-lang.org?subject=unsubscribe>
<http://lists.ruby-lang.org/cgi-bin/mailman/options/ruby-core>

In This Thread

Prev Next