feat: Use multiple threading for chunked upload #800
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 4322289600
💛 - Coveralls |
|
|
mwwoda
reviewed
Mar 3, 2023
Comment on lines
272
to
277
| value = upload_results.pop(0) | ||
| if isinstance(value, Exception): | ||
| time.sleep(randint(0, 1)) | ||
| raise value | ||
| time.sleep(randint(0, 1)) | ||
| return value |
Contributor
There was a problem hiding this comment.
You could move sleep before isinstance check and get rid of duplicated sleep call
Contributor
There was a problem hiding this comment.
Sure I was testing different delays for exc and actual response, but forgot to move it as I use now same value.
| for future in as_completed(futures): | ||
| future.result() | ||
| except Exception as exc: | ||
| self._executor.shutdown(wait=True) |
Contributor
There was a problem hiding this comment.
Looks like by default wait is set to True - https://docs.python.org/3/library/concurrent.futures.html
You could get rid of it if you want
Contributor
There was a problem hiding this comment.
I know, but I want to make it clear that we wait
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.