Skip to content

Conversation

@hoggatt
Copy link

@hoggatt hoggatt commented Feb 17, 2023

Fixes #495
when the sha1 hash is updated before the uploaded part actually succeeds and something happens that requires resuming, a digest mismatch error is thrown (see issue #495)

Fixes box#495
when the sha1 hash is updated before the uploaded part actually succeeds and something happens that requires resuming, a digest mismatch error is thrown (see issue box#495)
@CLAassistant
Copy link

CLAassistant commented Feb 17, 2023

CLA assistant check
All committers have signed the CLA.

@hoggatt hoggatt changed the title chunked uploader: fix resume error with sha1 hash fix: chunked uploader - fix resume error with sha1 hash Feb 17, 2023
@hoggatt
Copy link
Author

hoggatt commented Feb 17, 2023

Made this change locally and it ended up fixing the problem. Although I did also update from 3.2 to 3.6.2, but I'm guessing the issue wasn't fixed between those versions.

@arjankowski arjankowski changed the title fix: chunked uploader - fix resume error with sha1 hash fix: chunked uploader - fix resume error with sha1 hash Feb 20, 2023
@lukaszsocha2
Copy link
Contributor

Hi @hoggatt,
thanks for contributing. In recent pr (#800) we have introduced a feature to use multiple threads for chunk upload. Your change was also included in that pr, so I will close this one. New feature will be available soon in new release.
Best,
@lukaszsocha2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Chunked Uploader uses incorrect whole file digest upon resume

3 participants