Skip to content

Minor content and style changes #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 7, 2019
Merged

Minor content and style changes #72

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6895caa
Update package.json
zoltantothcom May 7, 2019
fb1c2d8
Update title subheading with better decription
zoltantothcom May 7, 2019
c75c374
Highlight pattern class headers in reference
zoltantothcom May 7, 2019
b6e5d8c
Update snapshots with subtitles content and styling changes
zoltantothcom May 7, 2019
dabaa4b
Update README with secure link to game
zoltantothcom May 7, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

Design Patterns - a quick game to test your familiarity with the 'Gang of Four' design patterns implemented in JS.

### :zap: [PLAY HERE](http://designpatternsgame.com/)
### :zap: [PLAY HERE](https://designpatternsgame.com/)

![Design Patterns - game results screenshot](/static/screenshot.png?sanitize=true&raw=true)

Expand Down
8 changes: 4 additions & 4 deletions __tests__/components/__snapshots__/Header.test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ exports[`<Header /> component renders with DARK theme 1`] = `
}

.c8 {
font: 400 0.925rem 'Karla',sans-serif;
font: 400 0.875rem 'Karla',sans-serif;
color: #C8C8C8;
margin: 0.75rem 0 0;
}
Expand Down Expand Up @@ -226,7 +226,7 @@ exports[`<Header /> component renders with DARK theme 1`] = `
<h2
className="c8"
>
implemented in JavaScript
“Gang of Four” patterns in JavaScript
</h2>
</div>
</header>
Expand Down Expand Up @@ -286,7 +286,7 @@ exports[`<Header /> component renders with LIGHT theme 1`] = `
}

.c8 {
font: 400 0.925rem 'Karla',sans-serif;
font: 400 0.875rem 'Karla',sans-serif;
color: #6F256F;
margin: 0.75rem 0 0;
}
Expand Down Expand Up @@ -459,7 +459,7 @@ exports[`<Header /> component renders with LIGHT theme 1`] = `
<h2
className="c8"
>
implemented in JavaScript
“Gang of Four” patterns in JavaScript
</h2>
</div>
</header>
Expand Down
5 changes: 5 additions & 0 deletions __tests__/components/__snapshots__/PatternsList.test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,11 @@ exports[`REFERENCE - Patterns List renders all the patterns 1`] = `
margin-top: 2.5rem;
}

.c0 h3 {
border-bottom: 1px solid;
padding-bottom: 1rem;
}

<div
className="c0"
>
Expand Down
8 changes: 4 additions & 4 deletions __tests__/components/__snapshots__/Title.test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ exports[`<Title /> component renders with a DARK theme 1`] = `
}

.c2 {
font: 400 0.925rem 'Karla',sans-serif;
font: 400 0.875rem 'Karla',sans-serif;
color: #C8C8C8;
margin: 0.75rem 0 0;
}
Expand All @@ -34,7 +34,7 @@ exports[`<Title /> component renders with a DARK theme 1`] = `
<h2
className="c2"
>
implemented in JavaScript
“Gang of Four” patterns in JavaScript
</h2>
</div>
`;
Expand All @@ -57,7 +57,7 @@ exports[`<Title /> component renders with a LIGHT theme 1`] = `
}

.c2 {
font: 400 0.925rem 'Karla',sans-serif;
font: 400 0.875rem 'Karla',sans-serif;
color: #6F256F;
margin: 0.75rem 0 0;
}
Expand All @@ -73,7 +73,7 @@ exports[`<Title /> component renders with a LIGHT theme 1`] = `
<h2
className="c2"
>
implemented in JavaScript
“Gang of Four” patterns in JavaScript
</h2>
</div>
`;
2 changes: 1 addition & 1 deletion __tests__/pages/__snapshots__/About.test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ exports[`About page renders with a DARK theme 1`] = `
}

.c1 {
color: #888888;
color: #F5F5F5;
margin-top: 2rem;
}

Expand Down
5 changes: 5 additions & 0 deletions __tests__/pages/__snapshots__/Patterns.test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,11 @@ exports[`Patterns page renders the Patterns list 1`] = `
margin-top: 2.5rem;
}

.c0 h3 {
border-bottom: 1px solid;
padding-bottom: 1rem;
}

<div
className="c0"
>
Expand Down
5 changes: 2 additions & 3 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
{
"name": "javascript-patterns",
"version": "0.1.0",
"private": true,
"name": "design-patterns-game",
"version": "1.0.0",
"dependencies": {
"prop-types": "^15.7.2",
"react": "^16.8.6",
Expand Down
6 changes: 6 additions & 0 deletions src/components/PatternsList.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,12 @@ const StyledPatterns = styled.div`
color: ${props => props.theme.header};
margin-top: 2.5rem;
}

h3 {
border-bottom: 1px solid ${props => props.theme.text};
color: ${props => props.theme.header};
padding-bottom: 1rem;
}
`;

const PatternsList = () => {
Expand Down
4 changes: 2 additions & 2 deletions src/components/Title.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,15 +18,15 @@ const Heading = styled.h1`
`;

const SubHeading = styled.h2`
font: 400 0.925rem 'Karla', sans-serif;
font: 400 0.875rem 'Karla', sans-serif;
color: ${props => props.theme.link};
margin: 0.75rem 0 0;
`;

export const Title = () => (
<TitleContainer>
<Heading>Design Patterns Game</Heading>
<SubHeading>implemented in JavaScript</SubHeading>
<SubHeading>&ldquo;Gang of Four&rdquo; patterns in JavaScript</SubHeading>
</TitleContainer>
);

Expand Down
2 changes: 1 addition & 1 deletion src/styles/themes/theme.dark.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ export const themeDark = {
toggleActiveBorder: C.SILVER,

// text and header
header: C.GRAY,
header: C.WILD_SAND,
text: C.SILVER,

border: C.TUNDORA
Expand Down