💡Good to provide incorrect answers at the end of the game #66
Conversation
1. variantUuid 2. color highlight with incorrect answers
| @@ -18,7 +18,6 @@ const patterns = [ | |||
| codeES5: 'Code ES5 - Prototype', | |||
| codeES6: 'Code ES6 - Prototype', | |||
| answered: false, | |||
| answerId: null, | |||
There was a problem hiding this comment.
answerId is same as uuid in the store
src/components/Button.jsx
Outdated
| </StyledButton> | ||
| ); | ||
| }; | ||
| export const Button = ({ id, label, onClick = () => {}, theme = {} }) => ( |
There was a problem hiding this comment.
Added theme to send the style of the button right in props
| }; | ||
| export const ButtonContainer = ({ current, onSubmitAnswer }) => ( | ||
| <StyledButtonContainer> | ||
| {current.variants.map(({ uuid, name }) => ( |
There was a problem hiding this comment.
moved all the logic below
|
|
||
| SyntaxHighlighter.registerLanguage('javascript', js); | ||
|
|
||
| const StyledButtonContainer = styled.div` |
There was a problem hiding this comment.
Copy-pasted the StyledButtonContainer
Can send it to helpers to get rid of repeats
| @@ -14,8 +14,8 @@ export const submitMiddleware = ({ getState }) => next => action => { | |||
|
|
|||
| const recentlyAnswered = { | |||
| ...filtered, | |||
| variantUuid: action.payload, | |||
There was a problem hiding this comment.
Saved variantUuid to compare it to the correct answer
| const allOtherAnswers = patternsWithUuids.filter(pattern => pattern.uuid !== current.uuid); | ||
| const additional = shuffle(allOtherAnswers).slice(0, 3); | ||
| // shuffle the 4 answers | ||
| const variants = shuffle([current, ...additional]); |
There was a problem hiding this comment.
answers should be tied to variants in order to show result incorrect answers
__tests__/Layout.test.js
Outdated
| @@ -18,7 +18,6 @@ const patterns = [ | |||
| codeES5: 'Code ES5 - Prototype', | |||
| codeES6: 'Code ES6 - Prototype', | |||
| answered: false, | |||
| answerId: null, | |||
| correct: null | |||
There was a problem hiding this comment.
💡I want to discuss the field correct as it is now computed as uuid === variantUuid 💡
Beraliv
changed the title
| answerId: null, | ||
| correct: null | ||
| correct: null, | ||
| variants: [{ |
There was a problem hiding this comment.
added variants and variantUuid for tests
|
What do you think @zoltantothcom? |
|
ping @zoltantothcom ? |
|
what do you think @zoltantothcom ? |
I think everyone would enjoy to learn design patterns based on incorrect answers, at least at the end of the game
So I:
TODO: