Adapt new standard library usages for compatibility with Zig 0.15.0 #2446
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zig 0.15.0-dev.1519 made std.ArrayList default to the unmanaged variant, breaking code that expected the managed one. Add per-file aliases where std.ArrayList is used: - ArrayListUnmanaged -> std.ArrayList - ArrayListManaged -> std.array_list.Managed Replace uses of std.ArrayList with ArrayListManaged where management is required, and std.ArrayListUnmanaged with the new default. Refers-To: ziglang/zig#24801 Signed-off-by: Rafael V. Volkmer <rafael.v.volkmer@gmail.com>
Zig 0.15.0-dev.XXXX renamed std.getWritten() to std.written(), deprecating the old function name. Update all occurrences of std.getWritten() to std.written() for consistency with the current Zig standard library. Refers-To: ziglang/zig#24826 Signed-off-by: Rafael V. Volkmer <rafael.v.volkmer@gmail.com>
RafaelVVolkmer
changed the title
RafaelVVolkmer
changed the title
RafaelVVolkmer
changed the title
RafaelVVolkmer
changed the title
Member
|
There are some changes that would need to be made to get this PR merged. To avoid any further delays in review, I am going to do this fix myself. Thank you for the effort nonetheless. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates zls to match recent Zig standard library changes:
1. Adapt to
std.ArrayListdefault change (ziglang/zig#24801)In Zig 0.15.0-dev.1519,
std.ArrayListnow defaults to the unmanaged variant, breaking code that assumed the managed version.Changes:
ArrayListUnmanaged→std.ArrayListArrayListManaged→std.array_list.Managedstd.ArrayListwithArrayListManagedwhere memory management is required.ArrayListUnmanagedwhere unmanaged behavior is desired.2. Migrate
std.getWritten()tostd.written()(ziglang/zig#24826)Zig replaced
std.getWritten()withstd.written(), deprecating the old function name.Changes:
std.getWritten()tostd.written()for consistency with the current API.