Skip to content

Comments

bigbang cert update#1471

Merged
Racer159 merged 1 commit intozarf-dev:mainfrom
radiusmethod:big-bang-cert-update
Mar 27, 2023
Merged

bigbang cert update#1471
Racer159 merged 1 commit intozarf-dev:mainfrom
radiusmethod:big-bang-cert-update

Conversation

@dgershman
Copy link
Contributor

Description

This updates the certificate for Big Bang which expired on February 25th.

Related Issue

No ticket was raised for this, but caught on the latest pull from main today.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Other (security config, docs update, etc)

Checklist before merging

@netlify
Copy link

netlify bot commented Mar 23, 2023

Deploy Preview for zarf-docs canceled.

Name Link
🔨 Latest commit 07e2154
🔍 Latest deploy log https://app.netlify.com/sites/zarf-docs/deploys/641fc2da7b7a7500082e588f

@dgershman
Copy link
Contributor Author

This reflects a change made in the Big Bang repository here: https://repo1.dso.mil/big-bang/bigbang/-/commit/a639d4382ce5480fdb25a34fb4dfa381597eb16e

Racer159
Racer159 previously approved these changes Mar 26, 2023
Copy link
Contributor

@Racer159 Racer159 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, will need sign off from @YrrepNoj as well

@Racer159
Copy link
Contributor

Also @dgershman it looks like your base branch will need updating from you prior to merge - https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/keeping-your-pull-request-in-sync-with-the-base-branch There should also be a setting that lets reviewers do it as well.

Copy link
Contributor

@Racer159 Racer159 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Racer159 Racer159 enabled auto-merge (squash) March 27, 2023 16:21
@Racer159 Racer159 merged commit f5d73a7 into zarf-dev:main Mar 27, 2023
@dgershman dgershman deleted the big-bang-cert-update branch March 27, 2023 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants