Skip to content

Conversation

@mischah
Copy link
Member

@mischah mischah commented Nov 4, 2022

This is a quick solution to fix #753

Purpose of this pull request?

  • Bug fix

What changes did you make?

Completely removed the insight module for now. So user tracking will be gone once this version is published.
I’ll be happy to bring back insight when the related work is done. Quoting from #753 to give context:

It’s not as easy as I thought 🙈
Because we have to update sindresorhus/os-name to v5.0.1 in yeoman/insight.

BUT: os-name is a pure ESM since 5.0.0. which means we have to change the module system in insight as well as described over here: https://gist.github.com/sindresorhus/a39789f98801d908bbc7ff3ecc99d99c

… which means we have to refactor yeoman/yo as well to make this work 😔

Is there anything you'd like reviewers to focus on?

@SBoudrias Do you think this is valid approach to get this bugfix out as soon as possible?

@mshima I saw that there were a lot of dependency updates with major version in the main branch since the last release.
Are we sure, that we don’t introduce a breaking change? I would love to publish this fix as a patch release.
I hope we can trust the tests so that yo still runs on Node 12.x 😬

This is a quick solution to fix #753
@mischah mischah requested review from SBoudrias and mshima November 4, 2022 19:48
@SBoudrias
Copy link
Member

LGTM, I don't think anyone of us is still looking at the insight data. So shouldn't have any big impact.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unable to run yo on macOS Ventura Beta

3 participants