Sourcery refactored master branch by sourcery-ai[bot] · Pull Request #1 · yelinaung/python

sourcery-ai · 2023-02-13T15:24:56Z

Branch master refactored by Sourcery.

If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.

See our documentation here.

Run Sourcery locally

Reduce the feedback loop during development by using the Sourcery editor plugin:

Review changes via command line

To manually merge these changes, make sure you're on the master branch, then run:

git fetch origin sourcery/master
git merge --ff-only FETCH_HEAD
git reset HEAD^

Help us improve this pull request!

sourcery-ai

Sourcery timed out performing refactorings.

Due to GitHub API limits, only the first 60 comments can be shown.

sourcery-ai · 2023-02-13T15:24:59Z

setup.py

        if ';' in line:
            requirement, _, specifier = line.partition(';')
-            for_specifier = EXTRAS.setdefault(':{}'.format(specifier), [])
+            for_specifier = EXTRAS.setdefault(f':{specifier}', [])


Lines 40-68 refactored with the following changes:

Replace call to format with f-string (use-fstring-for-formatting)

Replace interpolated string formatting with f-string (replace-interpolation-with-fstring)

sourcery-ai · 2023-02-13T15:24:59Z

doc/source/conf.py

-htmlhelp_basename = '%sdoc' % project
+htmlhelp_basename = f'{project}doc'

 # Grouping the document tree into LaTeX files. List of tuples
 # (source start file, target name, title, author, documentclass
 # [howto/manual]).
 latex_documents = [
-    ('index',
-     '%s.tex' % project,
-     u'%s Documentation' % project,
-     u'Kubernetes', 'manual'),
+    (
+        'index',
+        f'{project}.tex',
+        f'{project} Documentation',
+        u'Kubernetes',
+        'manual',
+    )


Lines 84-93 refactored with the following changes:

Replace interpolated string formatting with f-string [×3] (replace-interpolation-with-fstring)

sourcery-ai · 2023-02-13T15:25:00Z

examples/deployment_create.py

        resp = k8s_apps_v1.create_namespaced_deployment(
            body=dep, namespace="default")
-        print("Deployment created. status='%s'" % resp.metadata.name)
+        print(f"Deployment created. status='{resp.metadata.name}'")


Function main refactored with the following changes:

Replace interpolated string formatting with f-string (replace-interpolation-with-fstring)

sourcery-ai · 2023-02-13T15:25:00Z

examples/deployment_crud.py

-    # Instantiate the deployment object
-    deployment = client.V1Deployment(
+    return client.V1Deployment(
        api_version="apps/v1",
        kind="Deployment",
        metadata=client.V1ObjectMeta(name=DEPLOYMENT_NAME),
-        spec=spec)
-
-    return deployment
+        spec=spec,
+    )


Function create_deployment_object refactored with the following changes:

Inline variable that is immediately returned (inline-immediately-returned-variable)

This removes the following comments ( why? ):

# Instantiate the deployment object

sourcery-ai · 2023-02-13T15:25:00Z

examples/deployment_crud.py

-    print("Deployment created. status='%s'" % str(api_response.status))
+    print(f"Deployment created. status='{str(api_response.status)}'")


Function create_deployment refactored with the following changes:

Replace interpolated string formatting with f-string (replace-interpolation-with-fstring)

sourcery-ai · 2023-02-13T15:25:03Z

examples/remote_cluster.py

    # configuration.ssl_ca_cert="certificate"

-    aConfiguration.api_key = {"authorization": "Bearer " + aToken}
+    aConfiguration.api_key = {"authorization": f"Bearer {aToken}"}


Function main refactored with the following changes:

Use f-string instead of string concatenation (use-fstring-for-concatenation)

sourcery-ai · 2023-02-13T15:25:03Z

kubernetes/client/api_client.py

-                sub_kls = re.match(r'list\[(.*)\]', klass).group(1)
+                sub_kls = re.match(r'list\[(.*)\]', klass)[1]
                return [self.__deserialize(sub_data, sub_kls)
                        for sub_data in data]

            if klass.startswith('dict('):
-                sub_kls = re.match(r'dict\(([^,]*), (.*)\)', klass).group(2)
+                sub_kls = re.match(r'dict\(([^,]*), (.*)\)', klass)[2]


Function ApiClient.__deserialize refactored with the following changes:

Replace m.group(x) with m[x] for re.Match objects [×2] (use-getitem-for-re-match-groups)

sourcery-ai · 2023-02-13T15:25:03Z

kubernetes/client/api_client.py

-        if post_params:
-            params = post_params
-
+        params = post_params or []


Function ApiClient.prepare_post_parameters refactored with the following changes:

Move setting of default value for variable into else branch (introduce-default-else)

Unwrap a constant iterable constructor [×2] (unwrap-iterable-construction)

Simplify if expression by using or (or-if-exp-identity)

Replace if statement with if expression (assign-if-exp)

sourcery-ai · 2023-02-13T15:25:04Z

kubernetes/client/api_client.py

-            auth_setting = self.configuration.auth_settings().get(auth)
-            if auth_setting:
+            if auth_setting := self.configuration.auth_settings().get(auth):


Function ApiClient.update_params_for_auth refactored with the following changes:

Use named expression to simplify assignment and conditional (use-named-expression)

sourcery-ai · 2023-02-13T15:25:04Z

kubernetes/client/api_client.py

-        content_disposition = response.getheader("Content-Disposition")
-        if content_disposition:
-            filename = re.search(r'filename=[\'"]?([^\'"\s]+)[\'"]?',
-                                 content_disposition).group(1)
+        if content_disposition := response.getheader("Content-Disposition"):
+            filename = re.search(
+                r'filename=[\'"]?([^\'"\s]+)[\'"]?', content_disposition
+            )[1]


Function ApiClient.__deserialize_file refactored with the following changes:

Use named expression to simplify assignment and conditional (use-named-expression)

Replace m.group(x) with m[x] for re.Match objects (use-getitem-for-re-match-groups)

sourcery-ai · 2023-02-13T15:25:08Z

kubernetes/client/api_client.py

-            klass_name = instance.get_real_child_model(data)
-            if klass_name:
+            if klass_name := instance.get_real_child_model(data):


Function ApiClient.__deserialize_model refactored with the following changes:

Use named expression to simplify assignment and conditional (use-named-expression)

sourcery-ai · 2023-02-13T15:25:09Z

kubernetes/client/configuration.py

-    def __init__(cls, name, bases, dct):
-        super(TypeWithDefault, cls).__init__(name, bases, dct)
-        cls._default = None
+    def __init__(self, name, bases, dct):
+        super(TypeWithDefault, self).__init__(name, bases, dct)
+        self._default = None


Function TypeWithDefault.__init__ refactored with the following changes:

The first argument to instance methods should be self (instance-method-first-arg-name)

sourcery-ai · 2023-02-13T15:25:09Z

kubernetes/client/configuration.py

-    def __call__(cls):
-        if cls._default is None:
-            cls._default = type.__call__(cls)
-        return copy.copy(cls._default)
+    def __call__(self):
+        if self._default is None:
+            self._default = type.__call__(self)
+        return copy.copy(self._default)


Function TypeWithDefault.__call__ refactored with the following changes:

The first argument to instance methods should be self (instance-method-first-arg-name)

sourcery-ai · 2023-02-13T15:25:09Z

kubernetes/client/configuration.py

-    def set_default(cls, default):
-        cls._default = copy.copy(default)
+    def set_default(self, default):
+        self._default = copy.copy(default)


Function TypeWithDefault.set_default refactored with the following changes:

The first argument to instance methods should be self (instance-method-first-arg-name)

sourcery-ai · 2023-02-13T15:25:09Z

kubernetes/client/configuration.py

        # Logging Settings
-        self.logger = {}
-        self.logger["package_logger"] = logging.getLogger("client")
+        self.logger = {"package_logger": logging.getLogger("client")}


Function Configuration.__init__ refactored with the following changes:

Merge dictionary assignment with declaration (merge-dict-assign)

sourcery-ai · 2023-02-13T15:25:11Z