fix: update risk score fetching to use manifest files #552
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The risk-score repository has migrated from individual vault files
(vaults/{chainID}/{address}.json) to consolidated manifest files
(vaults/{chainID}.json). This caused RetrieveAvailableRiskScores to
find zero vaults since it was looking for a directory structure that
no longer exists.
Removed fetchVaultsRiskScore and RetrieveAllRiskScores functions that were making N individual vault requests after the manifest was already fetched. Also eliminated unnecessary GitHub API tree lookup by fetching manifest directly from CDN. This significantly simplifies the code and reduces HTTP requests from N+2 to 1 per chain, using only the CDN manifest. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude <noreply@anthropic.com>
murderteeth
approved these changes
Nov 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The risk-score repository has migrated from individual vault files (vaults/{chainID}/{address}.json) to consolidated manifest files (vaults/{chainID}.json). This caused RetrieveAvailableRiskScores to find zero vaults since it was looking for a directory structure that no longer exists.
Changes:
Benefits:
Review: Vaults to check when running fix:
missing here: https://ydaemon.yearn.fi/747474/vaults/0x78EC25FBa1bAf6b7dc097Ebb8115A390A2a4Ee12
exists here: https://github.com/yearn/risk-score/blob/e1e290a2348bfbb7d6f4cf2214f0b2a7505e13cc/vaults/747474.json#L121
missing here: https://ydaemon.yearn.fi/8453/vaults/0xb13CF163d916917d9cD6E836905cA5f12a1dEF4B
exists here: https://github.com/yearn/risk-score/blob/e1e290a2348bfbb7d6f4cf2214f0b2a7505e13cc/vaults/8453.json#L291
missing here: https://ydaemon.yearn.fi/8453/vaults/0x25f32eC89ce7732A4E9f8F3340a09259F823b7d3
exists here: https://github.com/yearn/risk-score/blob/e1e290a2348bfbb7d6f4cf2214f0b2a7505e13cc/vaults/8453.json#L70
missing here: https://ydaemon.yearn.fi/8453/vaults/0xc3BD0A2193c8F027B82ddE3611D18589ef3f62a9
exists here: https://github.com/yearn/risk-score/blob/e1e290a2348bfbb7d6f4cf2214f0b2a7505e13cc/vaults/8453.json#L359
missing here: https://ydaemon.yearn.fi/1/vaults/0x89E93172AEF8261Db8437b90c3dCb61545a05317
exists here: https://github.com/yearn/risk-score/blob/e1e290a2348bfbb7d6f4cf2214f0b2a7505e13cc/vaults/1.json#L988