Skip to content

Clarify Python 2+3 targeting chapter#2

Merged
yasoob merged 1 commit intoyasoob:masterfrom
phihag:patch-2
Aug 17, 2015
Merged

Clarify Python 2+3 targeting chapter#2
yasoob merged 1 commit intoyasoob:masterfrom
phihag:patch-2

Conversation

@phihag
Copy link
Contributor

@phihag phihag commented Aug 16, 2015

  • Make print code work and easier to understand by actually calling print
  • Fix heading that contained Markdown
  • Make sure code is PEP8-compliant.

It would be nice to give ipaddress a mention as well at the bottom.

* Make `print` code work and easier to understand by actually calling print
* Fix heading that contained Markdown
* Make sure code is PEP8-compliant.

It would be nice to give ipaddress a mention as well at the bottom.
yasoob added a commit that referenced this pull request Aug 17, 2015
Clarify Python 2+3 targeting chapter
@yasoob yasoob merged commit 4748338 into yasoob:master Aug 17, 2015
@yasoob
Copy link
Owner

yasoob commented Aug 17, 2015

I don't understand what you meant by ipaddress over there?

@phihag
Copy link
Contributor Author

phihag commented Aug 17, 2015

ipaddress is one the Python 3.x modules that has been backported. Since I did the backport myself, I did not want to add the mention myself.

JoshMcCullough added a commit to JoshMcCullough/intermediatePython that referenced this pull request Aug 24, 2015
**Note:** I changed 'method' to 'function' a lot so that it matches the rest of the book. However, I didn't change 'method' within the code examples. Then, in the last example, should point 1 and 2 be reversed? It seems yasoob#2 would happen before yasoob#1. But I may be wrong.
JoshMcCullough added a commit to JoshMcCullough/intermediatePython that referenced this pull request Aug 25, 2015
**Note:** In the last example, should point 1 and 2 be reversed? It seems yasoob#2 would happen before yasoob#1. But I may be wrong.
yasoob pushed a commit that referenced this pull request Oct 13, 2015
Update global_&_return.rst
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments