Merged
Conversation
… checks (#19266) DROP VIEW was incorrectly classified as DROP_TABLE in the PostgreSQL and Redshift statement type parsers (legacy compat with old pg_query_go parser). This caused non-materialized views to be marked as HIGH risk, triggering approval workflows unnecessarily. Non-materialized views hold no data, so dropping them is not destructive. Changes: - Parser: DROP VIEW now maps to DROP_VIEW (not DROP_TABLE) - Parser: DROP MATERIALIZED VIEW stays as DROP_TABLE (holds data) - Advisor: SCHEMA_BACKWARD_COMPATIBILITY no longer flags DROP VIEW - Both PostgreSQL and Redshift parsers updated Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
…tance in SaaS mode (#19267) * fix(frontend): fix GCP IAM credentials not sent when creating new instance in SaaS mode The `credentialSource` watcher that sets `iamExtension` on the data source was not `immediate`, so it missed the value change made by the earlier `isDefaultCredentialDisabled` watcher during component setup. This caused GCP/AWS/Azure IAM credentials to never be initialized on new instance creation in SaaS mode, falling back to default credentials which don't exist. Regression from #18161 which added the SaaS mode credential restriction. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * fix: remove unused parameter to pass eslint check Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * fix: format ternary to satisfy biome Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
* feat: remove auto_enable_backup from project settings Backup should be turned on explicitly by users since not all DMLs are data fixes. The backup feature is primarily used for data fixes with a few line changes. Changes: - Removed auto_enable_backup from proto/v1/v1/project_service.proto - Removed auto_enable_backup from proto/store/store/project.proto - Updated backend api and converters to remove the field - Updated frontend project settings panel to remove the switch - Updated plan initialization to default enablePriorBackup to false - Updated telemetry to remove auto_enable_backup reference - Removed auto-enable-backup from all locale files * feat: remove prior backup telemetry Since auto_enable_backup is removed, the telemetry for tracking its usage relative to project settings is no longer needed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )