refactor of preview to avoid rechunking#988
Merged
brendancol merged 3 commits intomasterfrom Mar 8, 2026
Merged
Conversation
_snap_factor no longer has a max_ratio gate — it always returns a divisor of the chunk size (falling back to 1). The rechunk path in _reduce_dask and _aligned_chunk_size are removed entirely. When the snapped factor overshoots the target (e.g. 1680 instead of 1000), a second pass computes the small intermediate and subsamples to the exact requested dimensions in-memory.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.