Add github option for --ci in scaffold package tests
#237
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wojtekn
approved these changes
Mar 20, 2024
wojtekn
left a comment
wojtekn
left a comment
There was a problem hiding this comment.
The change looks clear, and works fine:
% vendor/bin/wp scaffold package-tests wp-cli-shim --ci=github
Success: Created package test files.
danielbachhuber
approved these changes
Mar 21, 2024
danielbachhuber
requested changes
Mar 21, 2024
Member
danielbachhuber
left a comment
danielbachhuber
left a comment
There was a problem hiding this comment.
Can you add some basic tests for this?
Member
Author
|
@danielbachhuber PR has been updated. |
This reverts commit ddbf773.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #217
githuboption for--ciargument inscaffold package-testsbehat.yml- Same file from the root is copiedtesting.yml- Template file is kept atdot-github/workflowsfolder. This will be copied to.github/workflows