-
Notifications
You must be signed in to change notification settings - Fork 19
Add custom branch support to wp scaffold package-readme command
#206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swissspidy
approved these changes
Aug 10, 2022
swissspidy
reviewed
Aug 10, 2022
Co-authored-by: Pascal Birchler <pascal.birchler@gmail.com>
296ca18 to
4d7ac51
Compare
4d7ac51 to
4420edb
Compare
ccb9f6c to
edd0133
Compare
Contributor
Author
|
Test is passing now but as a side note |
Member
|
Seems like that's worth its own ticket, since this behavior is not new |
danielbachhuber
requested changes
Aug 11, 2022
Member
danielbachhuber
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking great so far! Left comments on a couple more things I'd like to see.
bad4e0b to
8e98a49
Compare
danielbachhuber
approved these changes
Aug 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #204