Skip to content

Conversation

@wojsmol
Copy link
Contributor

@wojsmol wojsmol commented Aug 10, 2022

fix #204

@wojsmol wojsmol requested a review from a team as a code owner August 10, 2022 12:04
Co-authored-by: Pascal Birchler <pascal.birchler@gmail.com>
@wojsmol wojsmol force-pushed the add/default-branch branch 4 times, most recently from 296ca18 to 4d7ac51 Compare August 10, 2022 12:57
@wojsmol wojsmol force-pushed the add/default-branch branch from 4d7ac51 to 4420edb Compare August 10, 2022 13:04
@wojsmol wojsmol force-pushed the add/default-branch branch from ccb9f6c to edd0133 Compare August 11, 2022 11:47
@wojsmol
Copy link
Contributor Author

wojsmol commented Aug 11, 2022

Test is passing now but as a side note wp scaffold package-readme --force returns a warning witch is IMHO unexpected

@swissspidy
Copy link
Member

Seems like that's worth its own ticket, since this behavior is not new

Copy link
Member

@danielbachhuber danielbachhuber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great so far! Left comments on a couple more things I'd like to see.

@wojsmol wojsmol force-pushed the add/default-branch branch from bad4e0b to 8e98a49 Compare August 11, 2022 15:24
@danielbachhuber danielbachhuber self-requested a review August 11, 2022 15:47
@danielbachhuber danielbachhuber added this to the 2.0.3 milestone Aug 11, 2022
@danielbachhuber danielbachhuber merged commit 0a8d5d1 into wp-cli:main Aug 11, 2022
@wojsmol wojsmol deleted the add/default-branch branch August 11, 2022 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support alternate default branches for CI badge

3 participants