Merge upstream into proxy-manager #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zenstruck#185) PHPStorm 2021.2+ has rudimentary generic annotation support.
Update maker factory template, add documentation about using with PhpStorm 2021.2+
…k#190) Co-authored-by: Wouter J <wouterj@users.noreply.github.com>
- fix regression in zenstruck#181 (closes zenstruck#192) - remove requirement to call `->withoutPersisting()` for embeddables
…ruck#195) Co-authored-by: Kevin Bond <kevinbond@gmail.com>
Add Symfony 5.4 to CI Matrix
This reverts commit 2ef6c6a.
…alm (zenstruck#217) Bumps [symfony/http-kernel](https://github.com/symfony/http-kernel) from 5.3.7 to 5.4.0. - [Release notes](https://github.com/symfony/http-kernel/releases) - [Changelog](https://github.com/symfony/http-kernel/blob/5.4/CHANGELOG.md) - [Commits](symfony/http-kernel@v5.3.7...v5.4.0) --- updated-dependencies: - dependency-name: symfony/http-kernel dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Add all-fields option to MakeFactory * Add interactive message to make all-fields option discoverable * Remove word from interactive message
* Add dependent field caution in index.rst * Change caution to note and reword * Move note to Attributes section
* Fix event hook argument name * Update php doc for the $proxy argument Co-authored-by: Kevin Bond <kevinbond@gmail.com> Co-authored-by: Kevin Bond <kevinbond@gmail.com>
Add allow-plugins for composer 2.2+
* [feature] Create ChainManagerRegistry in order to use doctrine/odm (zenstruck#151) * [feature] Handle schema reset for mongo (zenstruck#152) * Add tests for ODM * [tests] re-enable coverage with mongo * [tests] re-enable and fix static analysis * [feature] Support embedded objects for ODM (zenstruck#157) * [minor] fixed how tests are skipped (zenstruck#167) * (temp) set fast-fail: false * [minor] fix cs * [minor] fix deprecations * [minor] fix test suite * [bug] fix orm schema reset when using migrations * Revert "(temp) set fast-fail: false" This reverts commit 1b380f4. * tests: fix Proxy::fetchObject() for mongo (zenstruck#236) * test: assert make:factory can create both documents and embedded documents (zenstruck#237) * fix(odm): handle EmbedOne case (zenstruck#240) * [doc] mongo-support documentation (zenstruck#241) Co-authored-by: Nicolas PHILIPPE <nikophil@gmail.com>
…enstruck#257) Co-authored-by: Christopher Georg <christopher.georg@sr-travel.de>
This reverts commit fb79022.
Story pools
Fix global state issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
16 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I saw your PR zenstruck#127 but noticed it had conflicts.
I wanted to try it out so I fixed those for you.
origin/mastercomposer.jsonconflictZenstruck\Foundry\Tests\Functional\ProxyTesthad a few changes:protected static $POST_FACTORYso you could swap out the implementation when extending the baseProxyTest. However it appears the class now has an abstractpostFactoryClassmethod you can override. So I went ahead and used that instead.can_assert_not_persistedtest method has been added. It failed in yourProxyGeneratorTestbut I noticed other tests were skipped with aassertNotPersisted() is not supportedreason so I went ahead and skipped that failing test as well.