Check NRV visibility before modifying constraints#11550
Merged
ScoutHarris merged 2 commits intodevelopfrom Apr 25, 2019
Merged
Conversation
danielebogo
approved these changes
Apr 25, 2019
Contributor
danielebogo
left a comment
There was a problem hiding this comment.
Thanks @ScoutHarris for adding this! The code looks good and I never got a crash while I was testing it! ![]()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #11387
According to the Fabric logs, this crash seems to happen when searching the Free Photo Library.
I was not able to reproduce the crash, but this sort of crash typically happens when the NRV isn't actually visible so it fails when setting the constraints according to the
view. So I added a check to ensure the NRV is visible before setting the constraints. 🤞 this fixes it.To test:
Update release notes:
RELEASE-NOTES.txt.