ECC: generate values in range of order by rejection #7020
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SparkiDev
force-pushed
the
ecc_gen_k_by_reject
branch
2 times, most recently
from
3028ecc to
2790fc9
Compare
SparkiDev
force-pushed
the
ecc_gen_k_by_reject
branch
3 times, most recently
from
6061904 to
7e2a399
Compare
When generating private key and nonce for ECDSA, use rejection sampling. Note: SP uses this algorithm
SparkiDev
force-pushed
the
ecc_gen_k_by_reject
branch
from
7e2a399 to
21f53f3
Compare
dgarske
requested changes
Dec 14, 2023
Contributor
dgarske
left a comment
dgarske
left a comment
There was a problem hiding this comment.
Looks good otherwise. Just spelling
dgarske
approved these changes
Dec 14, 2023
Contributor
Author
|
Reporter is happy the new code is timing resistant. |
cconlon
approved these changes
Dec 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When generating private key and nonce for ECDSA, use rejection sampling. Note: SP uses this algorithm
Fixes zd#17099
Testing
./configure '--disable-shared' '--enable-ecccustcurves=all'
./configure '--disable-shared' '--enable-ecccustcurves=all' --enable-heapmath
./configure '--disable-shared' '--enable-ecccustcurves=all' --enable-fastmath
Checklist