Fix undesirable kyber dependencies when not building kyber (#2) #5619
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ejohnstown
approved these changes
Sep 22, 2022
ejohnstown
requested changes
Sep 22, 2022
Contributor
ejohnstown
left a comment
ejohnstown
left a comment
There was a problem hiding this comment.
What about wc_kyber_asm.S?
Contributor
Author
|
Excellent catch, thank you @ejohnstown sir. |
ejohnstown
approved these changes
Sep 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some IDE setups just pull in all source files in a given directory, only force errors when customers are trying to configure the kyber feature.
Add licensing even though these are just stubs.