enable filter lists for small non-downstream peers#3
Merged
johannwagner merged 1 commit intomainfrom Dec 14, 2022
Merged
Conversation
yu-re-ka
force-pushed
the
peer-filters
branch
2 times, most recently
from
088f71a to
2271f22
Compare
johannwagner
approved these changes
Dec 13, 2022
Contributor
johannwagner
left a comment
johannwagner
left a comment
There was a problem hiding this comment.
LGTM, but small nit pick and fix tests, please 😄
|
|
||
| if len(v4_set) == 0 and len(v6_set) == 0: | ||
| if len(v4_set) == 0 and len(v6_set) == 0 and self.is_customer: | ||
| l.error(f"{self.autos} has no v4 filter lists.") |
Contributor
There was a problem hiding this comment.
I fucked up the error message while moving this to as_filter.py, may you correct the message AND the exception?
yu-re-ka
force-pushed
the
peer-filters
branch
2 times, most recently
from
b308e03 to
55736e1
Compare
yu-re-ka
force-pushed
the
peer-filters
branch
from
55736e1 to
37c3824
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.