Make clear that transition:persist-props does not work without transition:persist#8740
Merged
sarah11918 merged 2 commits intomainfrom Jul 5, 2024
Merged
Make clear that transition:persist-props does not work without transition:persist#8740sarah11918 merged 2 commits intomainfrom
sarah11918 merged 2 commits intomainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
Contributor
Lunaria Status Overview🌕 This pull request will trigger status changes. Learn moreBy default, every PR changing files present in the Lunaria configuration's You can change this by adding one of the keywords present in the Tracked Files
Warnings reference
|
Member
Author
|
Newline changed at end of file. No idea where that came from nor how to get rid of it. |
sarah11918
approved these changes
Jul 5, 2024
Member
sarah11918
left a comment
sarah11918
left a comment
There was a problem hiding this comment.
Thank you for jumping on this so quickly, @martrapp ! 🫡
sarah11918
added
improve or update documentation
thomasbnt
added a commit
to thomasbnt/docs
that referenced
this pull request
Jul 8, 2024
Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>
yanthomasdev
added a commit
that referenced
this pull request
Jul 9, 2024
Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com> Co-authored-by: Yan <61414485+yanthomasdev@users.noreply.github.com>
forgetso
added a commit
to prosopo/docs
that referenced
this pull request
Jul 10, 2024
* Rework docs for Prosopo * i18n(zh-cn): Update `view-transitions.mdx` (withastro#8748) Co-authored-by: liruifengv <liruifeng1024@gmail.com> * i18n(zh-cn): Update `zerops.mdx` (withastro#8733) * i18n(zh-cn): Update `zerops.mdx` * Update src/content/docs/zh-cn/guides/deploy/zerops.mdx Co-authored-by: liruifengv <liruifeng1024@gmail.com> * Update src/content/docs/zh-cn/guides/deploy/zerops.mdx Co-authored-by: liruifengv <liruifeng1024@gmail.com> --------- Co-authored-by: liruifengv <liruifeng1024@gmail.com> * i18n(zh-cn): Update `markdown-content.mdx` (withastro#8734) * i18n(zh-cn): Update `markdown-content.mdx` * fix broken links --------- Co-authored-by: liruifengv <liruifeng1024@gmail.com> * i18n(zh-cn): Update `render.mdx` (withastro#8761) Co-authored-by: liruifengv <liruifeng1024@gmail.com> * linting * i18n(fr): Update `guides/view-transitions.mdx` from withastro#8740 (withastro#8758) Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com> Co-authored-by: Yan <61414485+yanthomasdev@users.noreply.github.com> * Fix vite build --------- Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com> Co-authored-by: Nin3 <30520689+Nin3lee@users.noreply.github.com> Co-authored-by: liruifengv <liruifeng1024@gmail.com> Co-authored-by: Thomas Bonnet <thomasbnt@protonmail.com> Co-authored-by: Yan <61414485+yanthomasdev@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description (required)
Docs are not super clear on how to use
transition:persist-props. Hopefully saying that it is an additional directive meant to be used together withtransition:persistmight help.Related issues & labels (optional)
See withastro/astro#10136.