Fix AbstractContainerScreenMixin crashing on NeoForge #333
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
The main reason why 1.21.5 was not updated is that I primarily support versions that are most used/easiest to help, combined with the latest version as a supporting version in between, as Minecraft's update cycle makes it really difficult to deal with supporting versions that will just be moved away from very quickly |
Author
|
That's totally understandable, I know constantly backporting features and fixes is a lot of work. I get it if you don't want to support 1.21.5 anymore, I just thought since it's a small fix I would make a PR for it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
keyPressedmethod has different params on NeoForge and Fabric, so I moved the mixin out of common and into each platform's respective AbstractContainerScreenMixin class and fixed the params. It looks like this fix was already implemented in 1.21.6+ branches, just not in 1.21.5.This resolves #330.