fix: Recover from having a local unestablished MLS group [WPB-21122] #19679

thisisamir98 · 2025-10-16T13:24:06Z

WPB-21122 [Web] Recover from having a local unestablished MLS group

Description

Problem scenario

If a client fails to establish a MLS conversation it might be left with a local MLS group in core crypto. Since this MLS group was never established it will be stuck epoch 0.

Since conversationExists()will return true clients will consider this conversation to be established even though it’s not.

Recovery

When trying to send a message in a conversation with a local MLS group stuck at epoch 0, delete the local MLS group and re-join the group / establish the group.

src/script/repositories/conversation/ConversationRepository.ts

Copilot

Pull Request Overview

This PR addresses a recovery mechanism for MLS conversations that fail to establish properly, leaving a local MLS group stuck at epoch 0. The changes enable the system to detect this failure state and attempt recovery by wiping the local MLS group and re-establishing it using the correct epoch from the backend.

Key Changes:

Added detection logic for MLS groups stuck at epoch 0 during message sending
Implemented recovery mechanism that wipes local MLS group and re-establishes with backend epoch
Refactored conversation establishment logic into separate methods for better maintainability

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

src/script/repositories/conversation/ConversationRepository.ts

…1112

sonarqubecloud · 2025-10-16T13:32:32Z

Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

codecov · 2025-10-16T13:37:22Z

Codecov Report

❌ Patch coverage is 7.69231% with 36 lines in your changes missing coverage. Please review.
✅ Project coverage is 43.62%. Comparing base (09ea856) to head (d1c83af).
⚠️ Report is 4 commits behind head on dev.

Additional details and impacted files

@@            Coverage Diff             @@
##              dev   #19679      +/-   ##
==========================================
- Coverage   43.65%   43.62%   -0.03%     
==========================================
  Files        1294     1294              
  Lines       32413    32440      +27     
  Branches     7198     7205       +7     
==========================================
+ Hits        14149    14153       +4     
- Misses      16565    16589      +24     
+ Partials     1699     1698       -1

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

e-maad

LGTM 👍

github-actions · 2025-10-16T14:00:41Z

🔗 Download Full Report Artifact

🧪 Playwright Test Summary

✅ Passed: 8
❌ Failed: 5
⏭ Skipped: 0
🔁 Flaky: 1
📊 Total: 14
⏱ Total Runtime: 1079.9s (~ 17 min 0 sec)

Failed Tests:

❌ Channels Management (tags: TC-8752, crit-flow-web)

Location: specs/CriticalFlow/channelsManagement-TC-8752.spec.ts:36
Duration: 74234ms

Errors:

TimeoutError: locator.waitFor: Timeout 20000ms exceeded.
Call log:
  - waiting for locator('[data-uie-name="item-message"] .message-body:not(:has(p.text-foreground)):has(.text)').last() to be visible


   at pageManager/webapp/pages/conversation.page.ts:160

  158 |     if (waitForVisibility) {
  159 |       // Wait for the last message to be visible
> 160 |       await this.messages.last().waitFor({state: 'visible', timeout: 20_000});
      |                                  ^
  161 |     }
  162 |
  163 |     // Then get all matching elements
    at ConversationPage.isMessageVisible (/home/runner/actions-runner/_work/wire-webapp/wire-webapp/test/e2e_tests/pageManager/webapp/pages/conversation.page.ts:160:34)
    at sendTextMessageToConversation (/home/runner/actions-runner/_work/wire-webapp/wire-webapp/test/e2e_tests/utils/userActions.ts:85:37)
    at /home/runner/actions-runner/_work/wire-webapp/wire-webapp/test/e2e_tests/specs/CriticalFlow/channelsManagement-TC-8752.spec.ts:158:5
    at /home/runner/actions-runner/_work/wire-webapp/wire-webapp/test/e2e_tests/specs/CriticalFlow/channelsManagement-TC-8752.spec.ts:157:3

❌ Planning group call with sending various messages during call (tags: TC-8632, crit-flow-web)

Location: specs/CriticalFlow/groupCalls-TC-8632.spec.ts:37
Duration: 24434ms

Errors:

Error: expect(received).toBeFalsy()

Received: true

  125 |     await test.step('Member unmutes themselves', async () => {
  126 |       await memberCalling.unmuteSelfInFullScreen();
> 127 |       expect(await memberCalling.isSelfUserMutedInFullScreen()).toBeFalsy();
      |                                                                 ^
  128 |     });
  129 |
  130 |     await test.step('Validation: Owner sees member is unmuted', async () => {
    at /home/runner/actions-runner/_work/wire-webapp/wire-webapp/test/e2e_tests/specs/CriticalFlow/groupCalls-TC-8632.spec.ts:127:65
    at /home/runner/actions-runner/_work/wire-webapp/wire-webapp/test/e2e_tests/specs/CriticalFlow/groupCalls-TC-8632.spec.ts:125:5

❌ Group Video call (tags: TC-8637, crit-flow-web)

Location: specs/CriticalFlow/groupVideoCall-TC-8637.spec.ts:39
Duration: 52239ms

Errors:

TimeoutError: locator.click: Timeout 20000ms exceeded.
Call log:
  - waiting for locator('[data-uie-name="item-call"]').locator('[data-uie-name="do-call-controls-call-accept"]')


   at pageManager/webapp/pages/calling.page.ts:66

  64 |
  65 |   async clickAcceptCallButton() {
> 66 |     await this.acceptCallButton.click();
     |                                 ^
  67 |   }
  68 |
  69 |   async clickToggleVideoButton() {
    at CallingPage.clickAcceptCallButton (/home/runner/actions-runner/_work/wire-webapp/wire-webapp/test/e2e_tests/pageManager/webapp/pages/calling.page.ts:66:33)
    at /home/runner/actions-runner/_work/wire-webapp/wire-webapp/test/e2e_tests/specs/CriticalFlow/groupVideoCall-TC-8637.spec.ts:147:34
    at /home/runner/actions-runner/_work/wire-webapp/wire-webapp/test/e2e_tests/specs/CriticalFlow/groupVideoCall-TC-8637.spec.ts:145:16

❌ New person joins team and setups up device (tags: TC-8635, crit-flow-web)

Location: specs/CriticalFlow/joinTeam-TC-8635.spec.ts:37
Duration: 49031ms

Errors:

Error: expect(locator).toBeVisible() failed

Locator: getByText('@Marisa Boyle')
Expected: visible
Error: strict mode violation: getByText('@Marisa Boyle') resolved to 2 elements:
    1) <span data-uie-name="secondary-line" class="conversation-list-cell-description conversation-list-cell-description--active">Whitney Hartmann: @Marisa Boyle</span> aka getByRole('button', { name: 'Open profile of Crits' })
    2) <span role="button" tabindex="-1" data-uie-name="label-self-mention" class="message-mention self-mention">…</span> aka getByTestId('label-self-mention')

Call log:
  - Expect "toBeVisible" with timeout 10000ms
  - waiting for getByText('@Marisa Boyle')


  151 |
  152 |     await test.step('A sees the mention in the chat', async () => {
> 153 |       await expect(pages.conversation().page.getByText(`@${memberA.fullName}`)).toBeVisible();
      |                                                                                 ^
  154 |     });
  155 |   },
  156 | );
    at /home/runner/actions-runner/_work/wire-webapp/wire-webapp/test/e2e_tests/specs/CriticalFlow/joinTeam-TC-8635.spec.ts:153:81
    at /home/runner/actions-runner/_work/wire-webapp/wire-webapp/test/e2e_tests/specs/CriticalFlow/joinTeam-TC-8635.spec.ts:152:16

❌ Messages in Groups (tags: TC-8751, crit-flow-web)

Location: specs/CriticalFlow/messagesInGroups-TC-8751.spec.ts:42
Duration: 43638ms

Errors:

TimeoutError: locator.waitFor: Timeout 20000ms exceeded.
Call log:
  - waiting for locator('[data-uie-name="item-message"] [data-uie-name="message-reactions"] button[data-uie-name="emoji-pill"][aria-label="1 reaction, react with +1 emoji"]').first() to be visible


   at pageManager/webapp/pages/conversation.page.ts:210

  208 |
  209 |     // Wait for at least one matching element to appear (optional timeout can be set)
> 210 |     await plusOneReactionIcon.first().waitFor({state: 'visible'});
      |                                       ^
  211 |
  212 |     return await plusOneReactionIcon.isVisible();
  213 |   }
    at ConversationPage.isPlusOneReactionVisible (/home/runner/actions-runner/_work/wire-webapp/wire-webapp/test/e2e_tests/pageManager/webapp/pages/conversation.page.ts:210:39)
    at /home/runner/actions-runner/_work/wire-webapp/wire-webapp/test/e2e_tests/specs/CriticalFlow/messagesInGroups-TC-8751.spec.ts:133:46
    at /home/runner/actions-runner/_work/wire-webapp/wire-webapp/test/e2e_tests/specs/CriticalFlow/messagesInGroups-TC-8751.spec.ts:129:5

Flaky Tests:

⚠️ Setting up new device with a backup (tags: TC-8634, crit-flow-web)

Location: specs/CriticalFlow/backupRestoration-TC-8634.spec.ts:35

Attempt 1
Result: ❌ Failed
Duration: 39368ms

Errors:

Error: locator.waitFor: Test ended.
Call log:
  - waiting for locator('[data-uie-name="item-message"] .message-body:not(:has(p.text-foreground)):has(.text)').last() to be visible


   at pageManager/webapp/pages/conversation.page.ts:160

  158 |     if (waitForVisibility) {
  159 |       // Wait for the last message to be visible
> 160 |       await this.messages.last().waitFor({state: 'visible', timeout: 20_000});
      |                                  ^
  161 |     }
  162 |
  163 |     // Then get all matching elements
    at ConversationPage.isMessageVisible (/home/runner/actions-runner/_work/wire-webapp/wire-webapp/test/e2e_tests/pageManager/webapp/pages/conversation.page.ts:160:34)
    at /home/runner/actions-runner/_work/wire-webapp/wire-webapp/test/e2e_tests/specs/CriticalFlow/backupRestoration-TC-8634.spec.ts:87:33
    at /home/runner/actions-runner/_work/wire-webapp/wire-webapp/test/e2e_tests/specs/CriticalFlow/backupRestoration-TC-8634.spec.ts:72:3

Attempt 2
Result: ✅ Passed
Duration: 42170ms

e-maad

LGTM 👍

fix: Recover from having a local unestablished MLS group [WPB-21112]

d97e4b4

thisisamir98 requested review from a team and otto-the-bot as code owners October 16, 2025 13:24

otto-the-bot added type: bug / fix 🐞 👕 size: M labels Oct 16, 2025

thisisamir98 requested review from Copilot and typfel and removed request for a team and otto-the-bot October 16, 2025 13:24

Merge branch 'dev' into WPB-21112

da343c9

typfel reviewed Oct 16, 2025

View reviewed changes

src/script/repositories/conversation/ConversationRepository.ts Outdated Show resolved Hide resolved

Copilot AI reviewed Oct 16, 2025

View reviewed changes

thisisamir98 added 5 commits October 16, 2025 15:29

better error

acfc1f6

better logging

d5943f9

comment

00c2477

Merge branch 'WPB-21112' of github.com:wireapp/wire-webapp into WPB-2…

1fa6e65

…1112

fix typo

d1c83af

thisisamir98 changed the title ~~fix: Recover from having a local unestablished MLS group [WPB-21112]~~ fix: Recover from having a local unestablished MLS group [WPB-21122] Oct 16, 2025

thisisamir98 requested a review from typfel October 16, 2025 13:43

e-maad reviewed Oct 16, 2025

View reviewed changes

e-maad approved these changes Oct 16, 2025

View reviewed changes

thisisamir98 merged commit 3b5c1ba into dev Oct 17, 2025
19 of 20 checks passed

thisisamir98 deleted the WPB-21112 branch October 17, 2025 11:26

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: Recover from having a local unestablished MLS group [WPB-21122] #19679

fix: Recover from having a local unestablished MLS group [WPB-21122] #19679

Uh oh!

thisisamir98 commented Oct 16, 2025 •

edited by github-actions bot

Loading

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sonarqubecloud bot commented Oct 16, 2025

Uh oh!

codecov bot commented Oct 16, 2025 •

edited

Loading

Uh oh!

e-maad left a comment

Uh oh!

github-actions bot commented Oct 16, 2025

Uh oh!

e-maad left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

fix: Recover from having a local unestablished MLS group [WPB-21122] #19679

fix: Recover from having a local unestablished MLS group [WPB-21122] #19679

Uh oh!

Conversation

thisisamir98 commented Oct 16, 2025 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Problem scenario

Recovery

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sonarqubecloud bot commented Oct 16, 2025

Quality Gate passed

Uh oh!

codecov bot commented Oct 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

e-maad left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Oct 16, 2025

🧪 Playwright Test Summary

Failed Tests:

Flaky Tests:

Uh oh!

e-maad left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

thisisamir98 commented Oct 16, 2025 •

edited by github-actions bot

Loading

codecov bot commented Oct 16, 2025 •

edited

Loading