feat: Support for CoreCrypto 9 [WPB-20699] #19608

thisisamir98 · 2025-09-30T15:05:51Z

WPB-20699 [Web] Upgrade to core crypto 9

Description

In new core crypto version 9 the wasm file is moved to src/autogenerated and this PR changes the webpack config to copy all of src directory contents flattened into the dist of webapp

github-actions · 2025-09-30T15:13:13Z

🔗 Download Full Report Artifact

🧪 Playwright Test Summary

✅ Passed: 8
❌ Failed: 6
⏭ Skipped: 0
🔁 Flaky: 0
📊 Total: 14
⏱ Total Runtime: 858.8s (~ 14 min 19 sec)

Failed Tests:

❌ Calls in channels with device switch and screenshare (tags: TC-8754, crit-flow-web)

Location: specs/CriticalFlow/channelsCall-TC-8755.spec.ts:38
Duration: 36951ms

Errors:

TimeoutError: locator.click: Timeout 20000ms exceeded.
Call log:
  - waiting for locator('[data-uie-name="go-next"]')


   at pageManager/webapp/pages/groupCreation.page.ts:49

  47 |
  48 |   async clickNextButton() {
> 49 |     await this.nextButton.click();
     |                           ^
  50 |   }
  51 |
  52 |   async clickCreateGroupButton() {
    at GroupCreationPage.clickNextButton (/home/runner/actions-runner/_work/wire-webapp/wire-webapp/test/e2e_tests/pageManager/webapp/pages/groupCreation.page.ts:49:27)
    at /home/runner/actions-runner/_work/wire-webapp/wire-webapp/test/e2e_tests/specs/CriticalFlow/channelsCall-TC-8755.spec.ts:88:40
    at /home/runner/actions-runner/_work/wire-webapp/wire-webapp/test/e2e_tests/specs/CriticalFlow/channelsCall-TC-8755.spec.ts:85:5

❌ Channels Management (tags: TC-8752, crit-flow-web)

Location: specs/CriticalFlow/channelsManagement-TC-8752.spec.ts:36
Duration: 43575ms

Errors:

TimeoutError: locator.click: Timeout 20000ms exceeded.
Call log:
  - waiting for locator('[data-uie-name="go-next"]')


   at pageManager/webapp/pages/groupCreation.page.ts:49

  47 |
  48 |   async clickNextButton() {
> 49 |     await this.nextButton.click();
     |                           ^
  50 |   }
  51 |
  52 |   async clickCreateGroupButton() {
    at GroupCreationPage.clickNextButton (/home/runner/actions-runner/_work/wire-webapp/wire-webapp/test/e2e_tests/pageManager/webapp/pages/groupCreation.page.ts:49:27)
    at /home/runner/actions-runner/_work/wire-webapp/wire-webapp/test/e2e_tests/specs/CriticalFlow/channelsManagement-TC-8752.spec.ts:72:33
    at /home/runner/actions-runner/_work/wire-webapp/wire-webapp/test/e2e_tests/specs/CriticalFlow/channelsManagement-TC-8752.spec.ts:69:3

❌ Planning group call with sending various messages during call (tags: TC-8632, crit-flow-web)

Location: specs/CriticalFlow/groupCalls-TC-8632.spec.ts:37
Duration: 24032ms

Errors:

Error: expect(received).toBeFalsy()

Received: true

  125 |     await test.step('Member unmutes themselves', async () => {
  126 |       await memberCalling.unmuteSelfInFullScreen();
> 127 |       expect(await memberCalling.isSelfUserMutedInFullScreen()).toBeFalsy();
      |                                                                 ^
  128 |     });
  129 |
  130 |     await test.step('Validation: Owner sees member is unmuted', async () => {
    at /home/runner/actions-runner/_work/wire-webapp/wire-webapp/test/e2e_tests/specs/CriticalFlow/groupCalls-TC-8632.spec.ts:127:65
    at /home/runner/actions-runner/_work/wire-webapp/wire-webapp/test/e2e_tests/specs/CriticalFlow/groupCalls-TC-8632.spec.ts:125:5

❌ Group Video call (tags: TC-8637, crit-flow-web)

Location: specs/CriticalFlow/groupVideoCall-TC-8637.spec.ts:39
Duration: 52762ms

Errors:

TimeoutError: locator.click: Timeout 20000ms exceeded.
Call log:
  - waiting for locator('[data-uie-name="item-call"]').locator('[data-uie-name="do-call-controls-call-accept"]')


   at pageManager/webapp/pages/calling.page.ts:66

  64 |
  65 |   async clickAcceptCallButton() {
> 66 |     await this.acceptCallButton.click();
     |                                 ^
  67 |   }
  68 |
  69 |   async clickToggleVideoButton() {
    at CallingPage.clickAcceptCallButton (/home/runner/actions-runner/_work/wire-webapp/wire-webapp/test/e2e_tests/pageManager/webapp/pages/calling.page.ts:66:33)
    at /home/runner/actions-runner/_work/wire-webapp/wire-webapp/test/e2e_tests/specs/CriticalFlow/groupVideoCall-TC-8637.spec.ts:147:34
    at /home/runner/actions-runner/_work/wire-webapp/wire-webapp/test/e2e_tests/specs/CriticalFlow/groupVideoCall-TC-8637.spec.ts:145:16

❌ Messages in Channels (tags: TC-8753, crit-flow-web)

Location: specs/CriticalFlow/messagesInChannels-TC-8753.spec.ts:44
Duration: 37300ms

Errors:

TimeoutError: locator.click: Timeout 20000ms exceeded.
Call log:
  - waiting for locator('[data-uie-name="go-next"]')


   at pageManager/webapp/pages/groupCreation.page.ts:49

  47 |
  48 |   async clickNextButton() {
> 49 |     await this.nextButton.click();
     |                           ^
  50 |   }
  51 |
  52 |   async clickCreateGroupButton() {
    at GroupCreationPage.clickNextButton (/home/runner/actions-runner/_work/wire-webapp/wire-webapp/test/e2e_tests/pageManager/webapp/pages/groupCreation.page.ts:49:27)
    at setupOwner (/home/runner/actions-runner/_work/wire-webapp/wire-webapp/test/e2e_tests/specs/CriticalFlow/messagesInChannels-TC-8753.spec.ts:78:42)
    at /home/runner/actions-runner/_work/wire-webapp/wire-webapp/test/e2e_tests/specs/CriticalFlow/messagesInChannels-TC-8753.spec.ts:89:7
    at /home/runner/actions-runner/_work/wire-webapp/wire-webapp/test/e2e_tests/specs/CriticalFlow/messagesInChannels-TC-8753.spec.ts:71:5

❌ Messages in Groups (tags: TC-8751, crit-flow-web)

Location: specs/CriticalFlow/messagesInGroups-TC-8751.spec.ts:42
Duration: 43601ms

Errors:

TimeoutError: locator.waitFor: Timeout 20000ms exceeded.
Call log:
  - waiting for locator('[data-uie-name="item-message"] [data-uie-name="message-reactions"] button[data-uie-name="emoji-pill"][aria-label="1 reaction, react with +1 emoji"]').first() to be visible


   at pageManager/webapp/pages/conversation.page.ts:210

  208 |
  209 |     // Wait for at least one matching element to appear (optional timeout can be set)
> 210 |     await plusOneReactionIcon.first().waitFor({state: 'visible'});
      |                                       ^
  211 |
  212 |     return await plusOneReactionIcon.isVisible();
  213 |   }
    at ConversationPage.isPlusOneReactionVisible (/home/runner/actions-runner/_work/wire-webapp/wire-webapp/test/e2e_tests/pageManager/webapp/pages/conversation.page.ts:210:39)
    at /home/runner/actions-runner/_work/wire-webapp/wire-webapp/test/e2e_tests/specs/CriticalFlow/messagesInGroups-TC-8751.spec.ts:133:46
    at /home/runner/actions-runner/_work/wire-webapp/wire-webapp/test/e2e_tests/specs/CriticalFlow/messagesInGroups-TC-8751.spec.ts:129:5

zskhan · 2025-10-07T15:58:49Z

src/script/mls/MLSConversations.ts

-    await conversationService.joinByExternalCommit(qualifiedId);
-    await addOtherSelfClientsToMLSConversation(mlsConversation, selfUserQualifiedId, core.clientId, core);
+    // otherwise we should try to ensure the conversation exists (this will establish it if epoch is 0, or join by external commit if epoch > 0)
+    console.info('Conversation does not exist, ensuring establishment');


console.info or logger.info?

…and clarify test description

codecov · 2025-10-08T11:21:48Z

Codecov Report

❌ Patch coverage is 36.53846% with 33 lines in your changes missing coverage. Please review.
✅ Project coverage is 43.64%. Comparing base (35ce2e5) to head (a01c5d8).
⚠️ Report is 1 commits behind head on dev.

Additional details and impacted files

@@            Coverage Diff             @@
##              dev   #19608      +/-   ##
==========================================
- Coverage   43.66%   43.64%   -0.02%     
==========================================
  Files        1294     1294              
  Lines       32318    32343      +25     
  Branches     7177     7183       +6     
==========================================
+ Hits        14111    14117       +6     
- Misses      16515    16531      +16     
- Partials     1692     1695       +3

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

sonarqubecloud · 2025-10-08T11:39:11Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

feat: Support for CoreCrypto 9 [WPB-20699]

b7c31b9

thisisamir98 requested review from a team and otto-the-bot as code owners September 30, 2025 15:05

otto-the-bot added type: feature / request ✨ 👕 size: XXL labels Sep 30, 2025

e-maad approved these changes Sep 30, 2025

View reviewed changes

zskhan approved these changes Sep 30, 2025

View reviewed changes

thisisamir98 added 3 commits October 1, 2025 18:34

improve logs

db1fb80

fix errors

695b7c5

fix lock file

bfeec64

aweiss-dev mentioned this pull request Oct 5, 2025

chore: remove legacy asset handling #19631

Merged

thisisamir98 added 2 commits October 7, 2025 17:52

recover semi reseted mls conversations

8b02e3e

Merge branch 'dev' of github.com:wireapp/wire-webapp into WPB-20699

612e631

zskhan reviewed Oct 7, 2025

View reviewed changes

zskhan approved these changes Oct 7, 2025

View reviewed changes

thisisamir98 added 2 commits October 8, 2025 12:49

bump core

ad75dcd

fix: align EnrollmentTimer test with implementation (notAfter field) …

a99af39

…and clarify test description

Merge branch 'dev' into WPB-20699

a01c5d8

thisisamir98 merged commit 33c3d07 into dev Oct 8, 2025
13 checks passed

thisisamir98 deleted the WPB-20699 branch October 8, 2025 11:46

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Support for CoreCrypto 9 [WPB-20699] #19608

feat: Support for CoreCrypto 9 [WPB-20699] #19608

Uh oh!

thisisamir98 commented Sep 30, 2025 •

edited by github-actions bot

Loading

Uh oh!

github-actions bot commented Sep 30, 2025 •

edited

Loading

Uh oh!

zskhan Oct 7, 2025

Uh oh!

codecov bot commented Oct 8, 2025 •

edited

Loading

Uh oh!

sonarqubecloud bot commented Oct 8, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

feat: Support for CoreCrypto 9 [WPB-20699] #19608

feat: Support for CoreCrypto 9 [WPB-20699] #19608

Uh oh!

Conversation

thisisamir98 commented Sep 30, 2025 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Uh oh!

github-actions bot commented Sep 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🧪 Playwright Test Summary

Failed Tests:

Uh oh!

zskhan Oct 7, 2025

Choose a reason for hiding this comment

Uh oh!

codecov bot commented Oct 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

sonarqubecloud bot commented Oct 8, 2025

Quality Gate passed

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

thisisamir98 commented Sep 30, 2025 •

edited by github-actions bot

Loading

github-actions bot commented Sep 30, 2025 •

edited

Loading

codecov bot commented Oct 8, 2025 •

edited

Loading