-
Notifications
You must be signed in to change notification settings - Fork 299
fix: Do not reuse cryptographic material #19539
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
thisisamir98
merged 6 commits into
master
from
bufix/logout-on-client-removed-wipe-MLS-WPB-19348
Sep 19, 2025
Merged
fix: Do not reuse cryptographic material #19539
thisisamir98
merged 6 commits into
master
from
bufix/logout-on-client-removed-wipe-MLS-WPB-19348
Sep 19, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aweiss-dev
approved these changes
Sep 18, 2025
przemvs
approved these changes
Sep 18, 2025
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #19539 +/- ##
==========================================
- Coverage 42.71% 42.64% -0.08%
==========================================
Files 1344 1342 -2
Lines 32601 32545 -56
Branches 7207 7194 -13
==========================================
- Hits 13927 13880 -47
+ Misses 17004 16998 -6
+ Partials 1670 1667 -3 🚀 New features to boost your workflow:
|
thisisamir98
added a commit
that referenced
this pull request
Sep 19, 2025
* chore: Bump @wireapp/core from 46.34.8 to 46.34.11(WPB-19348) * chore: lockfile changes * fix: call logout on signout reason client_removed and flush typing indicator * fix usage of legacy notifs --------- Co-authored-by: Amir Ghezelbash <thisisamir98@gmail.com>
thisisamir98
added a commit
that referenced
this pull request
Sep 19, 2025
* chore: Bump @wireapp/core from 46.34.8 to 46.34.11(WPB-19348) * chore: lockfile changes * fix: call logout on signout reason client_removed and flush typing indicator * fix usage of legacy notifs --------- Co-authored-by: Amir Ghezelbash <thisisamir98@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.



Description
bump core from 46.34.8 to 46.34.11, web-package-changes
Wipe identity + crypto + local history on CLIENT_REMOVED.
Add explicit flush of typing event on logout/socket teardown.
Checklist