fix: handle user.delete event [WPB-18869] #19440
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
V-Gira
commented
Aug 25, 2025
| amplify.publish(WebAppEvents.LIFECYCLE.SIGN_OUT, SIGN_OUT_REASON.ACCOUNT_DELETED, true); | ||
| }, 100); | ||
| } | ||
| this.emit('userDeleted', qualified_id); |
Contributor
Author
There was a problem hiding this comment.
emit the event to be consumed by the conversation repo.
User deletion events are not part of the WebAppEvents amplify store the conversation repo could use
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## dev #19440 +/- ##
==========================================
- Coverage 42.87% 42.86% -0.02%
==========================================
Files 1341 1341
Lines 32405 32422 +17
Branches 7174 7178 +4
==========================================
+ Hits 13895 13897 +2
- Misses 16843 16857 +14
- Partials 1667 1668 +1 🚀 New features to boost your workflow:
|
V-Gira
commented
Aug 25, 2025
| * Event to delete the matching user. | ||
| */ | ||
| private userDelete({id}: {id: string}): void { | ||
| private userDelete({qualified_id}: {qualified_id: QualifiedId}): void { |
Contributor
Author
There was a problem hiding this comment.
qualified_id required for CONVERSATION_EVENT.MEMBER_LEAVE event used to display a message in a conversation
V-Gira
commented
Aug 25, 2025
Comment on lines
2467
to
2481
| private readonly onUserDeleted = async (userId: QualifiedId) => { | ||
| const found1to1Conversation = this.conversationState.get1to1ConversationWithUser(userId); | ||
| if (!found1to1Conversation) { | ||
| return; | ||
| } | ||
|
|
||
| const deletedEvent = EventBuilder.buildMemberDeleted( | ||
| found1to1Conversation, | ||
| userId, | ||
| this.serverTimeHandler.toServerTimestamp(), | ||
| ); | ||
| await this.eventRepository.injectEvent(deletedEvent, EventRepository.SOURCE.INJECTED); | ||
| }; |
Contributor
Author
There was a problem hiding this comment.
inject a CONVERSATION_EVENT.MEMBER_LEAVE event in 1:1 conversation with a deleted user
Contributor
|
🔗 Download Full Report Artifact 🧪 Playwright Test Summary
Failed Tests:❌ Messages in Groups (tags: TC-8751, crit-flow-web)Location: specs/CriticalFlow/messagesInGroups-TC-8751.spec.ts:42 Errors: Flaky Tests: |
Comment on lines
+254
to
+264
| get1to1ConversationWithUser(userId: QualifiedId): Conversation | undefined { | ||
| const foundMLSConversation = this.findMLS1to1Conversation(userId); | ||
| if (foundMLSConversation) { | ||
| return foundMLSConversation; | ||
| } | ||
| const foundProteusConversations = this.findProteus1to1Conversations(userId); | ||
| if (foundProteusConversations && foundProteusConversations.length > 0) { | ||
| return foundProteusConversations[0]; | ||
| } | ||
| return undefined; | ||
| } |
Collaborator
There was a problem hiding this comment.
this looks like it could be one find operation only?
Contributor
Author
There was a problem hiding this comment.
you mean something like this?
get1to1ConversationWithUser(userId: QualifiedId): Conversation | undefined {
return this.conversations().find(
conv => isMLS1to1ConversationWithUser(userId)(conv) || isProteus1to1ConversationWithUser(userId)(conv)
);
}We need to return the MLS conversation first I think
Collaborator
There was a problem hiding this comment.
yes. but the original code isn't that bad either. i'll leave it up to you.
Comment on lines
665
to
682
| buildMemberDeleted( | ||
| conversationEntity: Conversation, | ||
| userId: QualifiedId, | ||
| currentTimestamp: number, | ||
| ): MemberLeaveEvent { | ||
| return { | ||
| ...buildQualifiedId(conversationEntity), | ||
| data: { | ||
| qualified_user_ids: [userId], | ||
| user_ids: [userId.id], | ||
| reason: MemberLeaveReason.USER_DELETED, | ||
| }, | ||
| from: userId.id, | ||
| time: conversationEntity.getNextIsoDate(currentTimestamp), | ||
| type: CONVERSATION_EVENT.MEMBER_LEAVE, | ||
| }; | ||
| }, | ||
|
|
Collaborator
There was a problem hiding this comment.
don't we have something for this already?
Contributor
Author
There was a problem hiding this comment.
yes, the buildMemberLeave builder, but it doesn't provide a MemberLeaveReason — in that case USER_DELETED
Collaborator
There was a problem hiding this comment.
can't we adjust it to provide the MemberLeaveReason?
thisisamir98
approved these changes
Aug 26, 2025
build user.delete event message inject memberleave event when a user is deleted add localisation string for user deleted event revert user event message changes revert user event message changes emit user.delete event
V-Gira
force-pushed
the
v/handle-user-deletion
branch
from
b7c8166 to
56255d1
Compare
|
V-Gira
added a commit
that referenced
this pull request
Aug 26, 2025
* fix: handle user.delete event build user.delete event message inject memberleave event when a user is deleted add localisation string for user deleted event revert user event message changes revert user event message changes emit user.delete event * display user deleted message if other member leave messages are not valid * remove DE localization string * replace buildMemberDelete with existing buildMember leave builder
4 tasks
V-Gira
added a commit
that referenced
this pull request
Aug 26, 2025
V-Gira
added a commit
that referenced
this pull request
Aug 27, 2025
* fix: handle user.delete event [WPB-18869] (#19440) * fix: handle user.delete event build user.delete event message inject memberleave event when a user is deleted add localisation string for user deleted event revert user event message changes revert user event message changes emit user.delete event * display user deleted message if other member leave messages are not valid * remove DE localization string * replace buildMemberDelete with existing buildMember leave builder * runfix: extend UserDeleteEvent type * correct typo, add german localization
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
user.deletebackend event are not being handled with 1:1 conversations with federated usersChecklist