fix: minimize the gap when reinitializing the media pipeline when the camera is turned on [WPB-17503] #19077
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- minimize the gap when reinitializing the media pipeline when the camera is turned on
Comment on lines
254
to
270
| {doVideoReconnecting && ( | ||
| <div className="group-video-grid__pause-overlay"> | ||
| <div className="background"> | ||
| <div className="background-image"></div> | ||
| <div className="background-darken"></div> | ||
| </div> | ||
|
|
||
| <div | ||
| className="group-video-grid__pause-overlay__label" | ||
| css={{fontsize: minimized ? '0.6875rem' : '0.875rem'}} | ||
| data-uie-name="status-video-paused" | ||
| > | ||
| {t('videoCallParticipantConnecting')} | ||
| </div> | ||
| {nameContainer} | ||
| </div> | ||
| )} |
Collaborator
There was a problem hiding this comment.
this sounds a bit redundant code to me, maybe we could merge the common parts with what we already have
Contributor
Author
There was a problem hiding this comment.
Ok i will adjust the template
|
thisisamir98
approved these changes
May 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We have a customized process when activating the camera. Since we can't adjust it without significant effort, we're minimizing the transition with this PR. AVS is now waiting for the encryption key until the new media pipeline is released.
Additionally, we have adapted the frontend to avoid black tiles.
Checklist