feat: Introduction of DDE_DATA_HOME and Path Adjustments#65
Open
sbaerlocher wants to merge 1 commit intowhatwedo:masterfrom
Open
feat: Introduction of DDE_DATA_HOME and Path Adjustments#65sbaerlocher wants to merge 1 commit intowhatwedo:masterfrom
DDE_DATA_HOME and Path Adjustments#65sbaerlocher wants to merge 1 commit intowhatwedo:masterfrom
Conversation
sbaerlocher
force-pushed
the
feature/move-data-home
branch
from
182d225 to
bbfcd9f
Compare
Contributor
|
Hello @sbaerlocher I think you need to check the nuke command in this file as well. :) |
s4mpl3d
requested changes
Sep 9, 2025
| echo ROOT_DIR=${ROOT_DIR} | ||
| echo DATA_DIR=${DATA_DIR} | ||
| echo CERT_DIR=${CERT_DIR} | ||
| _logYellow "DATA_DIR (Deprecated, use DDE_DATA_HOME) = ${DATA_DIR}" |
Member
There was a problem hiding this comment.
@sbaerlocher since its not a user-setting, we can fully remove data_dir from the code and just copy the ./data directory as boilerplate to the new path. This would also allow us to ship some default configuration
| fi | ||
|
|
||
| # Create dde.conf in the nginx conf.d directory if it doesn't exist | ||
| local nginxConfFile="$DDE_DATA_HOME/data/reverseproxy/etc/nginx/conf.d/dde.conf" |
Member
There was a problem hiding this comment.
This is not needed, if we treat the data directory in this repo as "defaults"
| fi | ||
|
|
||
| # Create config.yml if it doesn't exist | ||
| local configFile="$DDE_DATA_HOME/config.yml" |
Member
There was a problem hiding this comment.
where / why is this file needed? i dont see it referenced anywhere
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added
New Script
createDataHome.sh:_createDataHomefunction for creating theDDE_DATA_HOMEdirectory and migrating data fromDATA_DIR.DDE_DATA_HOME.Transition from
DATA_DIRtoDDE_DATA_HOMEincheckUpdate.sh:DDE_DATA_HOMEdirectory instead ofDATA_DIRfor update checks.Modified
Updates in
destroy.shandup.sh:CERT_DIRtoDDE_CERT_PATHfor handling SSL certificates.Environment Variable Updates in
systemDirectory (install.sh,env.sh,up.sh):DDE_DATA_HOMEandDDE_CERT_PATHenvironment variables, markingDATA_DIRandCERT_DIRas deprecated._createDataHomeinto bothinstall.shandupdate.sh.Removed
data/.gitkeep:Refactored
dde.shanddocker-compose.ymlAdjustments:DDE_DATA_HOMEandDDE_CERT_PATH.docker-compose.ymlto align with new directory structures.Related Issue