Merged
Conversation
Return as realpath to remove forward-slashs on Windows.
Use unlink to remove link. Only on Windows use rmdir to remove a link when its a dir.
- make shiftPathUp private
webflo
reviewed
Nov 24, 2016
| return realpath($path); | ||
| } | ||
|
|
||
| static function tempdir_remove($path) { |
Owner
There was a problem hiding this comment.
Lets define the visibility of this method.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added some more tests:
Symlinks are possible on Windows, needs to run as Admin.
Made shiftPathUp work on Windows with forward slashes in path.
@webflo you're allowed to commit to luenemam/test-symlink