test(security): add symlink-based path traversal attack tests #79
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add comprehensive tests for symlink traversal attack patterns in ValidatePathWithSymlinkResolution. These tests cover attack vectors that were not previously tested: - Relative symlinks with parent traversal (../outside/secret.txt) - Absolute symlinks to system paths (/etc, /tmp) - Nested symlinks in subdirectories escaping via multiple ../ - Symlink directory traversal via intermediate paths - Symlinks pointing to parent directory (..) - Triple and deeply chained symlinks (5 levels) - Symlink loops (circular references) - Mixed path traversal and symlink attacks - Disguised symlink traversal with innocent-looking names
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add comprehensive tests for symlink traversal attack patterns in
ValidatePathWithSymlinkResolution. These tests cover attack vectors
that were not previously tested: