test(security): achieve 100% test coverage for path.go #77
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add comprehensive tests for ValidateWorkingDirectory and ValidatePathWithSymlinkResolution to cover all error branches: - Introduce testable function variables (filepathRel, filepathEvalSymlinks, osLstat) to enable mock-based testing of error paths - Add mock tests for filepath.Rel errors in ValidateWorkingDirectory - Add mock tests for os.Lstat errors in ValidatePathWithSymlinkResolution - Add mock tests for EvalSymlinks errors on both fullPath and basePath - Add mock tests for filepath.Rel errors in symlink resolution - Add tests for ValidateWorkingDirectory error propagation in ValidatePathWithSymlinkResolution Coverage improved from 89.1% to 100%: - ValidateWorkingDirectory: 91.7% -> 100% - ValidatePathWithSymlinkResolution: 80.0% -> 100%
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add comprehensive tests for ValidateWorkingDirectory and
ValidatePathWithSymlinkResolution to cover all error branches:
osLstat) to enable mock-based testing of error paths
ValidatePathWithSymlinkResolution
Coverage improved from 89.1% to 100%: