Skip to content

Comments

fixes for handling multiple protocols in handshake#187

Closed
renej-github wants to merge 7 commits intowarmcat:masterfrom
renej-github:master
Closed

fixes for handling multiple protocols in handshake#187
renej-github wants to merge 7 commits intowarmcat:masterfrom
renej-github:master

Conversation

@renej-github
Copy link
Contributor

No description provided.

@warmcat
Copy link
Collaborator

warmcat commented Oct 29, 2014

Thanks, it's pushed.

@warmcat warmcat closed this Oct 29, 2014
@warmcat
Copy link
Collaborator

warmcat commented Dec 1, 2014

This patch makes the test client die talking to the test server as mentioned in #205, I had to revert it.

Can you propose a version that doesn't kill the test client?

@warmcat warmcat reopened this Dec 1, 2014
@renej-github
Copy link
Contributor Author

2014-12-01 12:47 GMT+01:00 Andy Green notifications@github.com:

This patch makes the test client die talking to the test server as
mentioned in #205 #205,
I had to revert it.

Can you propose a version that doesn't kill the test client?

I'll look into it

renej


Reply to this email directly or view it on GitHub
#187 (comment).

@warmcat
Copy link
Collaborator

warmcat commented Dec 1, 2014

Thanks.

@renej-github
Copy link
Contributor Author

server-client test as in #205 works again

@renej-github
Copy link
Contributor Author

There is still an issue with multiple protocol names like "my_protocol" and "my_protocol_2". Working on it...

@renej-github renej-github reopened this Dec 2, 2014
@renej-github
Copy link
Contributor Author

Still working on more robust subprotocol checking in client.c.

@renej-github
Copy link
Contributor Author

Seems to be ok now handling multiple (sub)protocols. Deals with situations like "my_protocol" and "my_protocol_2", sequence irrelevant. Server/client test runs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants