Skip to content

Conversation

ianbjacobs
Copy link
Collaborator

@ianbjacobs ianbjacobs commented Jun 26, 2018

…about not exposing user information, part of
#675


Preview | Diff

@marcoscaceres marcoscaceres self-requested a review June 28, 2018 14:29
index.html Outdated
<p>
One way that the API supports limited information sharing is through
the <a>redactList</a> associated with the
<a>onshippingaddresschange</a> event. This feature enables user
Copy link
Member

@marcoscaceres marcoscaceres Jun 28, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should probably change:

associated with the <a>onshippingaddresschange</a> event.

To:
used in the creation of <a>physical addresses</a> throughout the API.

Then that should cover us for when I add the billing address stuff

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've made a tweak based on your comment. I also added "tax information" alongside "shipping costs" as an example; that was mentioned in today's call.

@marcoscaceres marcoscaceres merged commit ebd8310 into gh-pages Jul 3, 2018
@marcoscaceres marcoscaceres deleted the priv_data_675 branch July 3, 2018 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants