Skip to content

fix minor problems #1649

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix minor problems #1649

wants to merge 3 commits into from

Conversation

bichikim
Copy link

@bichikim bichikim commented Mar 12, 2020 •
edited
Loading

  1. add types
  2. the rm command is not working in Windows OS (so use clean-webpack-plugin Instead)
if(a === 'b') {
  return true
}
return false

can be

return a === 'b'

  1. \/|\\|@ can be ([\/\\@])

  2. the Loader can be string also

posva
posva reviewed Mar 12, 2020
View reviewed changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@posva posva posva left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bichikim @posva