Skip to content

Conversation

@daleevans
Copy link

lib/PocketIO.pm had one license (Artistic 2.0) and LICENSE had another (Perl5 = GPL/Artistic). I assume that the LICENSE file was the correct one since it was more recent, and I suspect the other was boilerplate. Updated lib/PocketIO.pm to show what I believe is the correct license information and added the license information to minil.toml so that the META.* files will show license information as well.

Changelog diff is:

diff --git a/Changes b/Changes
index d5f9739..cad29f4 100644
--- a/Changes
+++ b/Changes
@@ -2,6 +2,10 @@ Revision history for perl module PocketIO

 {{$NEXT}}

+0.18 2015-04-18T23:38:57Z
+
+ - license
+
 0.17 2014-01-07T20:29:26Z

  - just meta files update
@vti
Copy link
Owner

vti commented Apr 19, 2015

Hi! Thanks for the PR, but Build.PL is automatically generated. The POD should probably be changed instead. I am using Minilla.

@daleevans
Copy link
Author

Sorry, I submitted a pretty messy pull request -- I actually reverted
all those changes to Build.PL, and only had a net diff of changes to
minil.toml and lib/PocketIO.pm. I've submitted a clean pull request that
is more clear as to what I meant :)

On 2015-04-18 9:52 PM, Viacheslav Tykhanovskyi wrote:

Hi! Thanks for the PR, but Build.PL is automatically generated. The
POD should probably be changed instead. I am using Minilla.


Reply to this email directly or view it on GitHub
#33 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants