utils: ComputeBounds: Consider vertex offset #1600
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es. See following:
This commit breaks ABI.
Collaborator
|
I think it would make sense to order the method members in the same order a VertexIndexDraw. |
Collaborator
|
I have merged this PR with the reordering of vertexOffset parameter to match vsg::DrawIndexed/vkCmdDrawIndexed ordering: eb0bfc3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HEADS UP: This commit breaks ABI. Might want to handle differently.
I was experimenting with some different buffer and vertex index draw configurations when i noticed compute bounds doesn't consider the VertexIndexDraw::vertexOffset member and returns incorrect results.