Skip to content

Conversation

@x1244
Copy link
Contributor

@x1244 x1244 commented Mar 15, 2025

On the Windows platform, the move and release events of a mouse button are not tagged identically. To accommodate the throw feature, the detection threshold for the timestamps of these two events is set within a 1-millisecond range. This configuration also supports the handling of events with identical timestamps under Xcb/X11.

Pull Request Template

Description

To better support the throw feature on Windows, the detection method for simultaneous mouse move and release events has been revised.

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

On my Windows system, releasing the left mouse button while in motion allows the scene to rotate effortlessly; however, if the left mouse button is released after the movement has ceased, the scene remains stationary at the position where the movement stopped.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

On the Windows platform, the move and release events of a mouse button are not tagged identically. To accommodate the throw feature, the detection threshold for the timestamps of these two events is set within a 1-millisecond range. This configuration also supports the handling of events with identical timestamps under Xcb/X11.
@robertosfield robertosfield merged commit 1f060c3 into vsg-dev:master Mar 17, 2025
8 checks passed
@robertosfield
Copy link
Collaborator

I have have merged the PR thanks. The code was getting a bit unwieldy so I've put in { } block for the if statement:

a93c1f5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants