Conversation
mezpusz
reviewed
Mar 30, 2026
| SortId sort() const { return _srt; } | ||
|
|
||
| TermSugar sort(SortId s) { _srt = s; return *this; } | ||
| TermSugar sort(SortId s) { return TermSugar(TermList(*this), s);} |
Contributor
There was a problem hiding this comment.
Based on the name I would expect that this function returns the sort, but in fact it makes the term sorted right? What do you think about naming it a bit more explicitly, like makeSorted or something similar?
mezpusz
reviewed
Mar 30, 2026
| std::ostream& Pretty<Literal>::prettyPrint(std::ostream& out) const | ||
| { | ||
| const Literal& lit = _self; | ||
| return out << lit; |
Contributor
There was a problem hiding this comment.
I think this should be removed, I added it for debug purposes.
mezpusz
reviewed
Mar 30, 2026
|
|
||
| bool unify(TermList t1, int bank1, TermList t2, int bank2, bool fixedPointIteration) | ||
| { | ||
| if (!this->unifyOnce(t1, bank1, t2, bank2)) return false; |
Contributor
There was a problem hiding this comment.
This could be just return this->unifyOnce(t1, bank1, t2, bank2) && (!fixedPointIteration || this->fixedPointIteration()), no?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #823, and creates unit tests capturing the bug.