Skip to content

Fix Windows Builds and Clippy Warnings #993

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
charlespierce merged 2 commits into from
May 10, 2021
Merged

Fix Windows Builds and Clippy Warnings #993

charlespierce merged 2 commits into from
May 10, 2021

Conversation

@charlespierce
Copy link
Contributor

@charlespierce charlespierce commented May 10, 2021

Info

  • As of the latest Rust release, Windows builds are failing to compile due to an issue with proc-macro-hack, which is a transitive dependency on Windows.
  • The upstream proc-macro-hack released a new version 0.4.3 that resolves the compiler failure.
  • Additionally, there are some warnings from Clippy on Windows that should be resolved.

Changes

  • Used cargo update to bump the version of proc-macro-hack in Cargo.lock
  • Fixed the clippy warnings.

Tested

  • Compiles on a Windows machine completely.
  • cargo clippy Shows no warnings.

@charlespierce charlespierce merged commit 2b45680 into volta-cli:main May 10, 2021
@charlespierce charlespierce deleted the cleanup branch May 10, 2021 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@charlespierce