chore: use httpdate to format expires #1877
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tottoto
force-pushed
the
use-httpdate-to-format-expires
branch
from
0d1831b to
6085b0e
Compare
chriskrycho
approved these changes
Aug 27, 2024
Contributor
chriskrycho
left a comment
chriskrycho
left a comment
There was a problem hiding this comment.
This is a nice win! Thanks!
This comment was marked as spam.
This comment was marked as spam.
Botyy1
approved these changes
Jul 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses
httpdatecrate to format expires. This simplify the implementation a little, and uses the samehttpdatecrate directly for encoding and decoding not depending on the specification or the internal implementation.