Skip to content

Conversation

@charlespierce
Copy link
Contributor

Closes #1209
Closes #1150
Closes #881

Info

  • With the release of Ubuntu 22.04, OpenSSL 3.0 is packaged by default and Volta is not currently built to link against that version.
  • As a short-term fix while we work out the blockers for statically linking, we should build a version of Volta linked with OpenSSL 3 on Linux
  • Since we haven't previously supported OpenSSL 3, this is an additive version and we don't need to maintain the backwards compatibility with older versions of glibc

Changes

  • Added a new docker file that sets up an Ubuntu 22.04 environment to build Volta (with OpenSSL 3)
  • Added a new job to the CI configuration that builds Volta in the above docker environment and uploads the release artifact
  • Updated the release CI job to pull in and publish the new OpenSSL binaries as well.
  • Bumped the native-tls and openssl versions in Cargo.lock to versions that support OpenSSL 3.
  • Also fixed a typo in the content-type we were sending for the release assets

Tested

  • Tested locally in a docker environment built by the docker image
  • Additional testing will depend on the CI runs.

@charlespierce charlespierce force-pushed the openssl_3 branch 2 times, most recently from 2a9d207 to b7f24d2 Compare April 22, 2022 17:48
asset_path: ./release/volta-centos.tar.gz
asset_name: volta-${{ steps.release_info.outputs.version }}-linux-openssl-rhel.tar.gz
asset_content_type: applictaion/gzip
asset_content_type: application/gzip
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeeeeeesh.

Copy link
Contributor

@chriskrycho chriskrycho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for doing this!

@charlespierce charlespierce merged commit 77db78b into volta-cli:main Apr 22, 2022
@charlespierce charlespierce deleted the openssl_3 branch April 22, 2022 22:12
felipecrs added a commit to felipecrs/dotfiles that referenced this pull request Apr 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

curl https://get.volta.sh | bash doesn't work on ubuntu 22.04 Openssl 3.0 support Download release fails if OpenSSL 3.0.0 installed

2 participants