Support flexible time split and merge policy for intelligent threshold #45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weilaaa
requested changes
Dec 18, 2025
veaiops/algorithm/intelligent_threshold/robust_daily_period_detector.py
Outdated
Show resolved
Hide resolved
veaiops/algorithm/intelligent_threshold/robust_daily_period_detector.py
Outdated
Show resolved
Hide resolved
veaiops/algorithm/intelligent_threshold/threshold_recommender.py
Outdated
Show resolved
Hide resolved
weilaaa
pushed a commit
that referenced
this pull request
Dec 23, 2025
#45) > Add a concise overview of what this PR aims to achieve. Reference related GitHub issues and PRs. Fixes # (issue) Please format the PR title as `{type}: {description}`. - **Types**: `feat`, `fix`, `refactor`, `chore`, `test`, `docs`. - **Example**: `feat: support new llm provider` - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] Documentation update - [ ] Refactoring (no functional changes, no api changes) > Please describe the tests that you ran to verify your changes. For UI changes or specific hardware integration, please provide screenshots or logs. - [ ] Unit Tests - [ ] Manual Verification - [ ] End-to-End Tests > If this PR introduces API changes or complex design modifications, please describe them here. ```python ``` - [ ] My code follows the style guidelines of this project. - [ ] I have run `pre-commit run --all-files` to ensure code quality. - [ ] I have performed a self-review of my own code. - [ ] I have commented my code, particularly in hard-to-understand areas. - [ ] I have made corresponding changes to the documentation. - [ ] I have added tests that prove my fix is effective or that my feature works.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes # (issue)
PR Title Format
Please format the PR title as
{type}: {description}.feat,fix,refactor,chore,test,docs.feat: support new llm providerType of Change
Testing
API and Design Changes (Optional)
# Example usage if applicableChecklist
pre-commit run --all-filesto ensure code quality.