Skip to content

add s390x assembly support + test #24129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
spytheman merged 2 commits into from
Apr 4, 2025
Merged

add s390x assembly support + test #24129

spytheman merged 2 commits into from
Apr 4, 2025

Conversation

@tankf33der
Copy link
Contributor

@tankf33der tankf33der commented Apr 3, 2025

My attempt to add s390x assembly.

Highlights:

  • Intel syntax
  • I tried creating asm in C code and gcc only accepted integer literals as naked 5
  • The test file is copied from a neighboring file. Not bad for a start

@huly-for-github
Copy link

huly-for-github bot commented Apr 3, 2025

Connected to Huly®: V_0.6-22520

@JalonSolov
Copy link
Contributor

JalonSolov commented Apr 3, 2025

Oops. Need to run v fmt -w on your files.

spytheman
spytheman approved these changes Apr 4, 2025
View reviewed changes
Copy link
Member

@spytheman spytheman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work.

@spytheman spytheman merged commit 4872e3c into vlang:master Apr 4, 2025
72 checks passed
@spytheman spytheman mentioned this pull request Apr 5, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@spytheman spytheman spytheman approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tankf33der @JalonSolov @spytheman