fix(examples): fix that a marker is not displayed due to an id collision#128
Merged
yotamberk merged 2 commits intovisjs:masterfrom Oct 7, 2019
ryamaguchi0220:issue/127
Merged
fix(examples): fix that a marker is not displayed due to an id collision#128yotamberk merged 2 commits intovisjs:masterfrom ryamaguchi0220:issue/127
yotamberk merged 2 commits intovisjs:masterfrom
ryamaguchi0220:issue/127
Conversation
yotamberk
requested changes
Oct 5, 2019
Member
yotamberk
left a comment
yotamberk
left a comment
There was a problem hiding this comment.
We appreciate the PR. Can you please refer to the review comments?
Comment on lines
33
to
34
| var id1 = '93b8a81c-c1fd-4800-9cdd-ee8d0ac445b0'; | ||
| var id2 = '19ddf917-5434-4bb8-a8c7-24ca09eb7e09'; |
Member
There was a problem hiding this comment.
Why a long uuid? Can we not simply use a simple id1 and id2 strings?
Contributor
Author
There was a problem hiding this comment.
I think both of id strings would not cause any problems in this case. So it seems certainly better to use the simple ids instead of the uuids.
yotamberk
approved these changes
Oct 7, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #127