[LAPACK] Add Arm Performance Libraries backend #633
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Augustin Degomme <augustin.degomme@sipearl.com> Co-authored-by: Nicolas Bouton <nicolas.bouton@sipearl.com> Co-authored-by: Romain Dolbeau <romain.dolbeau@sipearl.com>
sknepper
reviewed
Feb 24, 2025
Contributor
sknepper
left a comment
sknepper
left a comment
There was a problem hiding this comment.
Thank you for this awesome contribution! A few questions/comments from my side
include/oneapi/math/lapack/detail/armpl/onemath_lapack_armpl.hpp
Outdated
Show resolved
Hide resolved
Contributor
|
/intelci: run |
…triggered in Fortran lapack layer and just halt execution
sknepper
approved these changes
Feb 24, 2025
Contributor
sknepper
left a comment
sknepper
left a comment
There was a problem hiding this comment.
Thanks for all your work here! I just had one last question, but I don't think the extra code is harming anything.
We don't currently have any aarch64 systems to validate on, so thank you for validating on your side. Thanks again!
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds the Lapack backend for ArmPl on aarch64 CPUs.
Batch versions are not yet implemented.
Due to the LAPACKE interface used in ArmPl not exactly matching oneMath, some _scratchpad sizes are not queried and allocated/deallocated on the go (heevg, hegvd, .. which would need multiple work arrays with different sizes)
Checklist
All Submissions
log_lapack.txt
100% of the tests are reported as passing, which is an issue actually on the lapack backend (no skipped state, fix coming in another MR)