Fix mongo relationships

[abnegate]

Summary by CodeRabbit

• New Features

  • MongoDB adapter now supports relationship management and operations.

• Bug Fixes

  • Improved null field handling and special character escaping in MongoDB for better data integrity.

• Chores

  • Updated PHP runtime to version 8.4 with latest dependencies (Alpine 3.22, Redis 6.3.0, Swoole 6.1.6, MongoDB driver updates).

[coderabbitai]

📝 Walkthrough

Walkthrough

This PR upgrades the Docker environment from PHP 8.3 to 8.4 with updated extensions (Redis, Swoole) and implements MongoDB driver build fallback. The primary change enables relationship support in the MongoDB adapter with comprehensive update/delete logic, field escaping for Mongo compatibility, and null population for missing relationship fields.

Changes

Cohort / File(s)	Summary
Docker Environment Dockerfile	Bumps base image to php:8.4.18-cli-alpine3.22, updates extensions (Redis 6.3.0, Swoole v6.1.6), adds MongoDB driver pecl fallback with source build, replaces postgresql-dev with libpq-dev, updates extension paths to new hashed directories (no-debug-non-zts-20240924), and adjusts cleanup operations.
MongoDB Adapter Relationship Support src/Database/Adapter/Mongo.php	Enables relationship support (getSupportForRelationships returns true). Adds collection name variables, field escaping (escapeMongoFieldName, escapeQueryAttributes), guards for rename operations, metadata-driven junction naming for many-to-many relationships, projection-based query handling, and ensureRelationshipDefaults for null population of missing relationship fields.
Test Capability Guard tests/e2e/Adapter/Scopes/RelationshipTests.php	Adds adapter capability check in testStructureValidationAfterRelationsAttribute to skip assertions when adapter lacks attribute support.

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~60 minutes

Possibly related PRs

• Add comprehensive partial update + relationship tests #737 — Enables and implements Mongo relationship support with extensive relationship update/delete logic and adapter capability changes.
• Feat mongodb #721 — Updates Mongo adapter implementation and Docker configuration for Mongo driver setup.

Suggested reviewers

• fogelito

Poem

🐰 With Mongo's heart now bound by ties,
Relations bloom before our eyes—
Fields escape, nulls find their place,
While Docker builds in cyberspace,
PHP 8.4 leads the way,
Relationships flourish, hooray, hooray! 🌟

🚥 Pre-merge checks | ✅ 3 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 75.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title 'Fix mongo relationships' directly and specifically describes the main changes in the pull request, which focus on fixing relationship handling in the MongoDB adapter.
Merge Conflict Detection	✅ Passed	✅ No merge conflicts detected when merging into main

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch fix-mongo-relationships

---

No actionable comments were generated in the recent review. 🎉

🧹 Recent nitpick comments

src/Database/Adapter/Mongo.php (1)

797-807: $renameKey and $renameTwoWayKey are built with potentially null values.

When $newKey or $newTwoWayKey is null, $escapedNewKey / $escapedNewTwoWayKey will be null, creating ['$rename' => ['someKey' => null]]. These are guarded before use (e.g., line 811), so this doesn't cause a runtime issue today, but it's a latent risk if future code paths use these arrays without the guard.

Consider building rename operations lazily

-        $renameKey = [
-            '$rename' => [
-                $escapedKey => $escapedNewKey,
-            ]
-        ];
-
-        $renameTwoWayKey = [
-            '$rename' => [
-                $escapedTwoWayKey => $escapedNewTwoWayKey,
-            ]
-        ];

         // Build rename operations only when needed (inside each case branch)

Then inline them where used:

if (!\is_null($newKey) && $key !== $newKey) {
    $this->getClient()->update($collectionName, updates: ['$rename' => [$escapedKey => $escapedNewKey]], multi: true);
}

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 2

🤖 Fix all issues with AI agents

In @.gitignore:
- Line 1: The .gitignore was stripped to only "vendor/" which can cause
accidental commits of IDE and OS artifacts; restore the common ignore entries by
adding back .idea/, .DS_Store, mock.json, and data-tests.php (or explicitly
document that relying on a global gitignore is intentional) so contributors
don't commit editor or macOS metadata; update the .gitignore file to include
those patterns and commit the change.

In `@src/Database/Adapter/Mongo.php`:
- Around line 828-845: The many-to-many branch in updateRelationship (in
src/Database/Adapter/Mongo.php) builds the junction name as
collectionDoc.sequence + relatedCollectionDoc.sequence but ignores the $side
parameter, causing wrong junction selection when called from the child side;
modify the junction computation in updateRelationship to mirror
deleteRelationship / Database::getJunctionCollection logic by swapping the order
of collectionDoc and relatedCollectionDoc (or their sequences) when $side
indicates the child/context flip so the $junction variable matches the same
naming convention used elsewhere before performing the update/rename operations.

🧹 Nitpick comments (1)

Dockerfile (1)

36-45: Good resilience pattern for the MongoDB driver build.

The pecl-first-then-source-fallback approach is solid for handling Alpine compatibility issues. Minor note: the --recurse-submodules flag on git clone already initializes submodules, so the subsequent git submodule update --init --recursive on line 39 is redundant (but harmless).

Optional: remove redundant submodule init

  || (git clone --depth 1 --branch $PHP_MONGODB_VERSION --recurse-submodules https://github.com/mongodb/mongo-php-driver.git /tmp/mongodb \
       && cd /tmp/mongodb \
-      && git submodule update --init --recursive \
       && phpize \