Skip to content

Conversation

@rodinaarssen
Copy link
Member

Complex types were wrapped in an auxiliary object to avoid ambiguities between the JSON representation of containers and "lists as a sole argument" on the JSON-RPC level. This is not necessary, as complex types are not automatically deserializable through this path anyway. This PR removes wrapping around complex types, leaving rationals as the only values that are wrapped when encoding values as JSON objects.

FIxes usethesource/rascal-language-servers#944

@codecov
Copy link

codecov bot commented Jan 16, 2026

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 46%. Comparing base (3ba2f34) to head (10fbde8).

Files with missing lines Patch % Lines
src/org/rascalmpl/ideservices/GsonUtils.java 0% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##              main   #2599   +/-   ##
=======================================
  Coverage       46%     46%           
- Complexity    6623    6629    +6     
=======================================
  Files          793     793           
  Lines        65638   65631    -7     
  Branches      9831    9830    -1     
=======================================
+ Hits         30480   30485    +5     
+ Misses       32804   32787   -17     
- Partials      2354    2359    +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Breaking change - values returned from a rascal-meta-command are now nested within an outer object's val property

3 participants