This repository was archived by the owner on Apr 23, 2024. It is now read-only.
Conversation
aemkei
suggested changes
Jun 11, 2018
Member
aemkei
left a comment
aemkei
left a comment
There was a problem hiding this comment.
Nice find!
Only make sure to exclude the ferries and I'm fine with that.
|
|
||
| const API_KEY = 'fApLQBTwQbaIclmV0CoOQA'; | ||
| const TILE_BASE_URL = 'https://tile.nextzen.org/tilezen/vector/v1/256/all/'; | ||
| const EXCLUDE_ROAD_TYPES = ['ferry', 'path', 'minor_road', 'rail']; |
Member
There was a problem hiding this comment.
At least we should exclude the 'ferry' type here.
Contributor
Author
|
Excluded
|
Contributor
Author
|
Ah wait, there is still an error when merging the multiPolgons (the horizontal lines over the elbe) |
Contributor
Author
|
The problem are the tile borders in the MultiPolygons. Not sure how to fix that... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.